nastra commented on code in PR #9852: URL: https://github.com/apache/iceberg/pull/9852#discussion_r1535409457
########## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveOperationsBase.java: ########## @@ -76,10 +159,10 @@ default boolean exposeInHmsProperties() { return maxHiveTablePropertySize() > 0; } - default void setSchema(TableMetadata metadata, Map<String, String> parameters) { + default void setSchema(Schema tableSchema, Map<String, String> parameters) { Review Comment: ```suggestion default void setSchema(Schema schema, Map<String, String> parameters) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org