Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on PR #11216: URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2739877960 @deniskuzZ : Hi, Is Hive intersted in the incremental compute of these partition stats instead of reading all the manifests at once? If so, I am planning to add a new API to increm

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1998236833 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1998023614 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1998031053 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1998041969 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1993387221 ## core/src/main/java/org/apache/iceberg/SetPartitionStatistics.java: ## @@ -36,7 +35,10 @@ public SetPartitionStatistics(TableOperations ops) { @Override

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1995413058 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

aokolnychyi commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1992478432 ## core/src/main/java/org/apache/iceberg/SetPartitionStatistics.java: ## @@ -36,7 +35,10 @@ public SetPartitionStatistics(TableOperations ops) { @Override

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1993383799 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1993323183 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on PR #11216: URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2690823724 Thanks everyone for the review and merging it. This was a long awaited and super impactful feature. Hive, Trino, Dremio is waiting for it to be shipped. -- This is a

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on PR #11216: URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2690641023 Thanks for all your work @ajantha-bhat! Also thanks for all of the reviewers! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary merged PR #11216: URL: https://github.com/apache/iceberg/pull/11216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on PR #11216: URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2690498532 Just rebased the PR as there was a conflict from https://github.com/apache/iceberg/pull/12419 in `TestTables` -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on PR #11216: URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2687054193 @RussellSpitzer, @aokolnychyi: Anymore comments? others have approved the changes. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Data: Add partition stats writer and reader [iceberg]

jbonofre commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1970109787 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Data: Add partition stats writer and reader [iceberg]

jbonofre commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1970108920 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Data: Add partition stats writer and reader [iceberg]

jbonofre commented on PR #11216: URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2682520892 I did the review and it looks good to me. Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1969601484 ## core/src/main/java/org/apache/iceberg/SetPartitionStatistics.java: ## @@ -36,7 +35,10 @@ public SetPartitionStatistics(TableOperations ops) { @Override

Re: [PR] Data: Add partition stats writer and reader [iceberg]

gaborkaszab commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1969209511 ## core/src/main/java/org/apache/iceberg/SetPartitionStatistics.java: ## @@ -36,7 +35,10 @@ public SetPartitionStatistics(TableOperations ops) { @Override

Re: [PR] Data: Add partition stats writer and reader [iceberg]

gaborkaszab commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1969140073 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1968046827 ## core/src/test/java/org/apache/iceberg/TestTables.java: ## @@ -79,17 +79,7 @@ public static TestTable create( PartitionSpec spec, SortOrder sortO

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1968046827 ## core/src/test/java/org/apache/iceberg/TestTables.java: ## @@ -79,17 +79,7 @@ public static TestTable create( PartitionSpec spec, SortOrder sortO

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1968045379 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1968041114 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1968039303 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

gaborkaszab commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1967872485 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

gaborkaszab commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1967808710 ## core/src/test/java/org/apache/iceberg/TestTables.java: ## @@ -79,17 +79,7 @@ public static TestTable create( PartitionSpec spec, SortOrder sortOr

Re: [PR] Data: Add partition stats writer and reader [iceberg]

gaborkaszab commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1946350566 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on PR #11216: URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2671333629 @pvary: Thanks a lot for the review and approval. Yeah, we can wait till next week for @gaborkaszab. By that time @aokolnychyi may also review this if he gets time. -- This

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1963462471 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,289 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1963130151 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,289 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on PR #11216: URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2670469872 Rebased and PR is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on PR #11216: URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2668800302 @pvary, @gaborkaszab: I have addressed the comments. Please check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1961772494 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1961772043 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1961771559 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1961765409 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1961697310 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1961376054 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1961373018 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1961367545 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1961364417 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1961038669 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1960061400 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1960059571 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1953427985 ## core/src/test/java/org/apache/iceberg/TestTables.java: ## @@ -93,6 +93,26 @@ public static TestTable create( return new TestTable(ops, name, reporter);

Re: [PR] Data: Add partition stats writer and reader [iceberg]

gaborkaszab commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1952317886 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1950061705 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1950048200 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1950039374 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1950023950 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1950036853 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1950032898 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1950014481 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1950004069 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on PR #11216: URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2646947773 I was travelling for past four days. Will be taking a look at the new comments tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Data: Add partition stats writer and reader [iceberg]

gaborkaszab commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1946313092 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1944505874 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1941240868 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1941247104 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1941219705 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1941204512 ## core/src/test/java/org/apache/iceberg/TestTables.java: ## @@ -93,6 +93,26 @@ public static TestTable create( return new TestTable(ops, name, reporter); } +

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1941197057 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -133,4 +134,27 @@ private static Collection mergeStats( return statsMap.values(); } +

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1941192206 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1941184059 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940558710 ## core/src/test/java/org/apache/iceberg/TestTables.java: ## @@ -93,6 +93,26 @@ public static TestTable create( return new TestTable(ops, name, reporter);

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on PR #11216: URL: https://github.com/apache/iceberg/pull/11216#issuecomment-2632944341 thanks @pvary for the review. I have addressed the comments except (https://github.com/apache/iceberg/pull/11216#discussion_r1939040414), It is because I wanted to keep the sig

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940544107 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940542661 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940542661 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940541813 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940535942 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940531115 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940531115 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940512306 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940510235 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940509287 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -133,4 +134,27 @@ private static Collection mergeStats( return statsMap.values();

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940508650 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939049410 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939070271 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939057416 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939049410 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939043730 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939041619 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939040414 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939036304 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939030560 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939029933 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939025938 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939015974 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939012670 ## data/src/main/java/org/apache/iceberg/data/PartitionStatsHandler.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939011161 ## core/src/test/java/org/apache/iceberg/TestTables.java: ## @@ -93,6 +93,26 @@ public static TestTable create( return new TestTable(ops, name, reporter); } +

Re: [PR] Data: Add partition stats writer and reader [iceberg]

pvary commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939006203 ## core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java: ## @@ -133,4 +134,27 @@ private static Collection mergeStats( return statsMap.values(); } +

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1937236363 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add partition stats writer and reader [iceberg]

deniskuzZ commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1937122625 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1937114400 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Data: Add partition stats writer and reader [iceberg]

deniskuzZ commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1936923827 ## data/src/test/java/org/apache/iceberg/data/TestPartitionStatsHandler.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1777915925 ## core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java: ## @@ -370,17 +371,17 @@ public void testPartitionStatsWithSchemaEvolution() throws Except

Re: [PR] Data: Add partition stats writer and reader [iceberg]

ajantha-bhat commented on code in PR #11216: URL: https://github.com/apache/iceberg/pull/11216#discussion_r1777912510 ## core/src/main/java/org/apache/iceberg/PartitionStats.java: ## @@ -249,4 +250,45 @@ public void set(int pos, T value) { throw new UnsupportedOperatio

  1   2   >