ajantha-bhat commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1993387221
##########
core/src/main/java/org/apache/iceberg/SetPartitionStatistics.java:
##########
@@ -36,7 +35,10 @@ public SetPartitionStatistics(TableOperations ops) {
@Override
public UpdatePartitionStatistics
setPartitionStatistics(PartitionStatisticsFile file) {
- Preconditions.checkArgument(null != file, "partition statistics file must
not be null");
+ if (file == null) {
Review Comment:
We went little back and forth on this.
For the end users, it avoids extra null check if the stats are null by going
with no-op. So, went ahead with no-op
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
