ajantha-bhat commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1940558710
##########
core/src/test/java/org/apache/iceberg/TestTables.java:
##########
@@ -93,6 +93,26 @@ public static TestTable create(
return new TestTable(ops, name, reporter);
}
+ public static TestTable create(
+ File temp,
+ String name,
+ Schema schema,
+ PartitionSpec spec,
+ int formatVersion,
+ Map<String, String> properties) {
Review Comment:
Followed a similar style when they added `MetricsReporter`,
> Why not adding the parameter to the old create
It is public. So, need to modify all the callers.
But we can refactor a private method that can be helper to all these public
method. I can do it in a follow up to keep minimal changes for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
