ajantha-bhat commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1969601484
##########
core/src/main/java/org/apache/iceberg/SetPartitionStatistics.java:
##########
@@ -36,7 +35,10 @@ public SetPartitionStatistics(TableOperations ops) {
@Override
public UpdatePartitionStatistics
setPartitionStatistics(PartitionStatisticsFile file) {
- Preconditions.checkArgument(null != file, "partition statistics file must
not be null");
+ if (file == null) {
Review Comment:
I checked Trino & Spark Puffin implementation, caller is making sure it is
not null.
```
IcebergMetadata#finishStatisticsCollection() in Trino
ComputeTableStatsSparkAction#execute() in spark
```
API level NPE is not a good idea. I am ok with no-op as it avoids extra null
handling for the callers.
So, I don't think we need to revert back again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
