pvary commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1939011161
##########
core/src/test/java/org/apache/iceberg/TestTables.java:
##########
@@ -93,6 +93,26 @@ public static TestTable create(
return new TestTable(ops, name, reporter);
}
+ public static TestTable create(
+ File temp,
+ String name,
+ Schema schema,
+ PartitionSpec spec,
+ int formatVersion,
+ Map<String, String> properties) {
Review Comment:
Why not adding the parameter to the old `create` method and call the new
method from the old one?
Like:
```
public static TestTable create(
File temp,
String name,
Schema schema,
PartitionSpec spec,
SortOrder sortOrder,
int formatVersion) {
return create(temp, name, schema, spec, SortOrder.unsorted(),
formatVersion, ImmutableMap.of());
}
public static TestTable create(
File temp,
String name,
Schema schema,
PartitionSpec spec,
int formatVersion,
Map<String, String> properties) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
