Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-10-19 Thread via GitHub
github-actions[bot] closed pull request #9503: Core: Fix setting updated parquet compression property URL: https://github.com/apache/iceberg/pull/9503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-10-19 Thread via GitHub
github-actions[bot] commented on PR #9503: URL: https://github.com/apache/iceberg/pull/9503#issuecomment-2424319115 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-10-12 Thread via GitHub
github-actions[bot] commented on PR #9503: URL: https://github.com/apache/iceberg/pull/9503#issuecomment-2408755023 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-31 Thread via GitHub
rdblue commented on PR #9503: URL: https://github.com/apache/iceberg/pull/9503#issuecomment-1919889634 It looks like we don't have consensus that this is the right direction, so I'm going to at least remove it from the 1.5.0 milestone. We can discuss it more at the next community sync maybe

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-26 Thread via GitHub
aokolnychyi commented on PR #9503: URL: https://github.com/apache/iceberg/pull/9503#issuecomment-1912799517 Is there a problem in persisting these properties even if the underlying file format is not Parquet? -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-23 Thread via GitHub
rdblue commented on PR #9503: URL: https://github.com/apache/iceberg/pull/9503#issuecomment-1906654805 @amogh-jahagirdar, I'm not sure I agree with this change. It seems to me that this is the Parquet default regardless of whether the default write format is Avro or ORC. It's a format-speci

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-19 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1459520414 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map per

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-19 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1459520414 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map per

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1458258796 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map per

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
manuzhang commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1458161912 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map persistedP

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1458123535 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map per

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1458123535 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map per

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1458112966 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map per

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1458112966 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map per

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
manuzhang commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1458104584 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map persistedP

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1457704960 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map per

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1457704960 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map per

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
manuzhang commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1457640453 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map persistedP

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
manuzhang commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1457640453 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map persistedP

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1457616434 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1729,6 +1729,46 @@ public void testNoTrailingLocationSlash() { meta.location()

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-18 Thread via GitHub
nastra commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1457112913 ## core/src/test/java/org/apache/iceberg/TestTableMetadata.java: ## @@ -1729,6 +1729,46 @@ public void testNoTrailingLocationSlash() { meta.location()); }

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-17 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1456949302 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map per

Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-17 Thread via GitHub
amogh-jahagirdar commented on code in PR #9503: URL: https://github.com/apache/iceberg/pull/9503#discussion_r1456949302 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,10 +90,19 @@ private static Map unreservedProperties(Map rawP private static Map per

[PR] Core: Fix setting updated parquet compression property [iceberg]

2024-01-17 Thread via GitHub
amogh-jahagirdar opened a new pull request, #9503: URL: https://github.com/apache/iceberg/pull/9503 Fixes #9490 . As part of 1.4.0 we made the default compression for Parquet to zstd. However, this property is being set for every new table regardless of the underlying file formats (e