Re: [PR] Core: Fix setting updated parquet compression property [iceberg]

[via GitHub]

amogh-jahagirdar commented on code in PR #9503:
URL: https://github.com/apache/iceberg/pull/9503#discussion_r1459520414


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -90,10 +90,19 @@ private static Map<String, String> 
unreservedProperties(Map<String, String> rawP
   private static Map<String, String> persistedProperties(Map<String, String> 
rawProperties) {
     Map<String, String> persistedProperties = Maps.newHashMap();
 
+    String format =
+        rawProperties.getOrDefault(

Review Comment:
   ![Screenshot from 2024-01-19 
09-22-10](https://github.com/apache/iceberg/assets/87500546/32641a91-58c7-4548-a2eb-24387af51c6e)
   ![Screenshot from 2024-01-19 
10-25-19](https://github.com/apache/iceberg/assets/87500546/dc135124-4546-489b-aedd-20450c13e95a)
   
   Here is a smoke test with ORC format in Trino before and after the change. 
Before the change the test passes because Parquet compression was defined with 
ZSTD, after there's no such table property.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org