amogh-jahagirdar commented on code in PR #9503:
URL: https://github.com/apache/iceberg/pull/9503#discussion_r1458123535
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -90,10 +90,19 @@ private static Map<String, String>
unreservedProperties(Map<String, String> rawP
private static Map<String, String> persistedProperties(Map<String, String>
rawProperties) {
Map<String, String> persistedProperties = Maps.newHashMap();
+ String format =
+ rawProperties.getOrDefault(
Review Comment:
Well if I think about it, what we are persisting at the table property level
is a default for the table. Whether or not the Flink/Spark write options
override at runtime doesn't really matter. For example, if they override with
ORC in the runtime option and we end up persisting parquet compression doesn't
really matter because if they later perform a write *without* the runtime
operation we would be writing ZSTD parquet because we would be falling back to
the table property.
I could see it being confusing though if everyone overrides their engine
config for all their writes (always specifying in the write option) rather than
the table property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
