nastra commented on code in PR #9503:
URL: https://github.com/apache/iceberg/pull/9503#discussion_r1457112913
##########
core/src/test/java/org/apache/iceberg/TestTableMetadata.java:
##########
@@ -1729,6 +1729,46 @@ public void testNoTrailingLocationSlash() {
meta.location());
}
+ @Test
+ public void testCompressionDefaultPropertyForParquet() {
+ Map<String, String> properties =
+ ImmutableMap.of(TableProperties.DEFAULT_FILE_FORMAT,
FileFormat.PARQUET.name());
+ TableMetadata metadata =
+ TableMetadata.newTableMetadata(
+ TEST_SCHEMA, SPEC_5, SORT_ORDER_3, "/some-location/", properties);
+
+
Assertions.assertThat(metadata.property(TableProperties.PARQUET_COMPRESSION,
null))
+ .withFailMessage(
Review Comment:
I don't think we should be using `withFailMessage()` because it will hide
all contextual information and will only show this message. We rather want to
use `.as()` in all of these cases here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
