amogh-jahagirdar commented on code in PR #9503:
URL: https://github.com/apache/iceberg/pull/9503#discussion_r1458112966


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -90,10 +90,19 @@ private static Map<String, String> 
unreservedProperties(Map<String, String> rawP
   private static Map<String, String> persistedProperties(Map<String, String> 
rawProperties) {
     Map<String, String> persistedProperties = Maps.newHashMap();
 
+    String format =
+        rawProperties.getOrDefault(

Review Comment:
   Ah I see, you're talking about the dynamic write configuration options that 
exist at the engine level ("write-format") for Spark and Flink. Yeah that's 
true, this doesn't really address that case which maybe could be confusing for 
users. I'll think a bit more about a good solution for that then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to