amogh-jahagirdar commented on code in PR #9503:
URL: https://github.com/apache/iceberg/pull/9503#discussion_r1458258796
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -90,10 +90,19 @@ private static Map<String, String>
unreservedProperties(Map<String, String> rawP
private static Map<String, String> persistedProperties(Map<String, String>
rawProperties) {
Map<String, String> persistedProperties = Maps.newHashMap();
+ String format =
+ rawProperties.getOrDefault(
Review Comment:
I believe it should since in Trino the only way to specify the format is
just at the table property.
Trino does not have any session properties in the Iceberg connector for
overriding the file format at runtime as far as I can tell.
https://github.com/trinodb/trino/blob/master/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergSessionProperties.java#L57
I'll run an end to end test with Trino and this PR to make sure this PR does
solve the problem in #9490.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
