advancedxy commented on PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#issuecomment-2579123258
Thanks all for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
amogh-jahagirdar merged PR #10755:
URL: https://github.com/apache/iceberg/pull/10755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
amogh-jahagirdar commented on PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#issuecomment-2575953987
I'll go ahead and merge, the remaining comment(s) are something we can clean
up in a follow on! Thank you for your patience and great work @advancedxy ,
really appreciate it! t
rdblue commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1905832698
##
core/src/main/java/org/apache/iceberg/UpdateRequirements.java:
##
@@ -173,6 +175,27 @@ private void update(MetadataUpdate.SetDefaultSortOrder
unused) {
}
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1904445943
##
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##
@@ -1284,6 +1284,62 @@ public void testUpdateTableSpecThenRevert() {
assertThat(t
advancedxy commented on PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#issuecomment-2573229194
@rdblue @danielcweeks @amogh-jahagirdar would you mind to take a look at
this again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
advancedxy commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1893563419
##
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##
@@ -209,6 +217,25 @@ private TableMetadata internalApply() {
.forEach(idsToRemove::add);
advancedxy commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1893563085
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1102,6 +1121,22 @@ public Builder setDefaultPartitionSpec(int specId) {
return this;
rdblue commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1892730070
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1102,6 +1121,22 @@ public Builder setDefaultPartitionSpec(int specId) {
return this;
}
rdblue commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1892723041
##
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##
@@ -209,6 +217,25 @@ private TableMetadata internalApply() {
.forEach(idsToRemove::add);
advancedxy commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1890353291
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,17 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @return this
rdblue commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1889283765
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,17 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @return this for
rdblue commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1889284613
##
core/src/main/java/org/apache/iceberg/IncrementalFileCleanup.java:
##
@@ -273,7 +275,7 @@ private Set findFilesToDelete(
Set manifestsToScan,
Set mani
advancedxy commented on PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#issuecomment-2541354779
@danielcweeks would you mind to take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
amogh-jahagirdar commented on PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#issuecomment-2517891980
Thanks @advancedxy , I'll leave it open for a bit since @danielcweeks also
mentioned he would take a look. But from my side everything LGTM.
--
This is an automated message f
advancedxy commented on PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#issuecomment-2517786865
@amogh-jahagirdar @nastra since all comments are addressed, do you think
it's ready to merge? I'm happy to address more comments if needed.
--
This is an automated message from the
advancedxy commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1868635951
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1108,6 +1108,25 @@ public Builder setDefaultPartitionSpec(int specId) {
return this;
advancedxy commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1868635560
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @return this
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1866315984
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @retur
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1866324210
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1108,6 +1108,25 @@ public Builder setDefaultPartitionSpec(int specId) {
return thi
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1866324210
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1108,6 +1108,25 @@ public Builder setDefaultPartitionSpec(int specId) {
return thi
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1866330705
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1108,6 +1108,25 @@ public Builder setDefaultPartitionSpec(int specId) {
return thi
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1866324210
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1108,6 +1108,25 @@ public Builder setDefaultPartitionSpec(int specId) {
return thi
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1866324210
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1108,6 +1108,25 @@ public Builder setDefaultPartitionSpec(int specId) {
return thi
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1866315984
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @retur
advancedxy opened a new pull request, #10755:
URL: https://github.com/apache/iceberg/pull/10755
This is a continue work of #3462, all the credits should goes to
@RussellSpitzer.
Previously there was no way to remove partition specs from a table once they
were
added. To fix this we
advancedxy closed pull request #10755: API: Support removeUnusedSpecs in
ExpireSnapshots
URL: https://github.com/apache/iceberg/pull/10755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
advancedxy commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1860976419
##
core/src/main/java/org/apache/iceberg/UpdateRequirements.java:
##
@@ -173,6 +175,27 @@ private void update(MetadataUpdate.SetDefaultSortOrder
unused) {
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1856448261
##
core/src/main/java/org/apache/iceberg/UpdateRequirements.java:
##
@@ -173,6 +175,27 @@ private void update(MetadataUpdate.SetDefaultSortOrder
unused) {
}
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1856450913
##
core/src/main/java/org/apache/iceberg/UpdateRequirements.java:
##
@@ -173,6 +175,27 @@ private void update(MetadataUpdate.SetDefaultSortOrder
unused) {
}
advancedxy commented on PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#issuecomment-2496541354
@nastra @amogh-jahagirdar PTAL again, I think all your comments are
addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1853408518
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @return this for
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1853077549
##
core/src/main/java/org/apache/iceberg/UpdateRequirements.java:
##
@@ -173,6 +175,26 @@ private void update(MetadataUpdate.SetDefaultSortOrder
unused) {
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1853082951
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @retur
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1853077549
##
core/src/main/java/org/apache/iceberg/UpdateRequirements.java:
##
@@ -173,6 +175,26 @@ private void update(MetadataUpdate.SetDefaultSortOrder
unused) {
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1853077549
##
core/src/main/java/org/apache/iceberg/UpdateRequirements.java:
##
@@ -173,6 +175,26 @@ private void update(MetadataUpdate.SetDefaultSortOrder
unused) {
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1852462124
##
core/src/main/java/org/apache/iceberg/UpdateRequirements.java:
##
@@ -173,6 +175,26 @@ private void update(MetadataUpdate.SetDefaultSortOrder
unused) {
}
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1852460646
##
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##
@@ -1108,6 +1108,24 @@ public Builder setDefaultPartitionSpec(int specId) {
return this;
}
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1852387515
##
core/src/test/java/org/apache/iceberg/TestUpdateRequirements.java:
##
@@ -424,6 +424,89 @@ public void setDefaultPartitionSpecFailure() {
.hasMessage("Requ
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1852353595
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @return this for
advancedxy commented on PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#issuecomment-2482921541
@nastra Thanks for reviewing, all your comments should be addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1837955891
##
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##
@@ -1284,6 +1284,35 @@ public void testUpdateTableSpecThenRevert() {
assertThat(table.spec(
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1837956539
##
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##
@@ -1284,6 +1284,35 @@ public void testUpdateTableSpecThenRevert() {
assertThat(table.spec(
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1837955470
##
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##
@@ -1620,6 +1621,90 @@ public void testRetainFilesOnRetainedBranches() {
assertThat(deletedF
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1837955153
##
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##
@@ -1620,6 +1621,90 @@ public void testRetainFilesOnRetainedBranches() {
assertThat(deletedF
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1837948631
##
core/src/main/java/org/apache/iceberg/UpdateRequirements.java:
##
@@ -173,6 +175,26 @@ private void update(MetadataUpdate.SetDefaultSortOrder
unused) {
}
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1837947793
##
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##
@@ -126,6 +127,9 @@ private MetadataUpdateParser() {}
// SetCurrentViewVersion
private sta
nastra commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1837945532
##
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##
@@ -126,6 +127,9 @@ private MetadataUpdateParser() {}
// SetCurrentViewVersion
private sta
advancedxy commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1837531744
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @return this
advancedxy commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1830509009
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @return this
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1829925773
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @retur
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1829925773
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @retur
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1829925773
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @retur
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1829925773
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @retur
RussellSpitzer commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1829907218
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @return
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1829747078
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @retur
amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1829690607
##
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##
@@ -118,4 +118,16 @@ public interface ExpireSnapshots extends
PendingUpdate> {
* @retur
57 matches
Mail list logo
