amogh-jahagirdar commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1866324210
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1108,6 +1108,25 @@ public Builder setDefaultPartitionSpec(int specId) {
return this;
}
+ Builder removeSpecIds(Iterable<Integer> specIds) {
Review Comment:
I think I'd prefer this be called `removeSpecs`. If we look at the other
APIs on TableMetadata builder like `setDefaultPartitionSpec(int specId)` it
aligns with that naming, I don't think we need the "Ids" suffix. In case we
ever need a removeSpecs which takes in actual PartitionSpec we'd just overload
at that time just like setDefaultPartitionSpec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
