rdblue commented on code in PR #10755: URL: https://github.com/apache/iceberg/pull/10755#discussion_r1889283765
########## api/src/main/java/org/apache/iceberg/ExpireSnapshots.java: ########## @@ -118,4 +118,17 @@ public interface ExpireSnapshots extends PendingUpdate<List<Snapshot>> { * @return this for method chaining */ ExpireSnapshots cleanExpiredFiles(boolean clean); + + /** + * Allows expiration of unreachable table layout metadata, such as partition specs as part of the + * operation. + * + * @param clean setting this to true will remove table layout metadata that is no longer reachable + * by any snapshot Review Comment: This is a bit verbose. I'd recommend being more direct and not making it a full sentence. Something like: > remove unused partition specs, schemas, or other metadata when true The same could apply to the method description: > Enable cleaning up unused partition specs, schemas, or other metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org