Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

rdblue merged PR #9592: URL: https://github.com/apache/iceberg/pull/9592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

rdblue commented on PR #9592: URL: https://github.com/apache/iceberg/pull/9592#issuecomment-1953240958 I'm going to merge this to unblock @ggershinsky and we can continue discussing the `create` method changes in a follow up. Thanks, @RussellSpitzer! -- This is an automated message from t

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

rdblue commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1495065683 ## api/src/main/java/org/apache/iceberg/io/FileIO.java: ## @@ -42,6 +46,30 @@ default InputFile newInputFile(String path, long length) { return newInputFile(path);

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

rdblue commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1495063672 ## api/src/main/java/org/apache/iceberg/encryption/EncryptingFileIO.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

RussellSpitzer commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1495000442 ## api/src/main/java/org/apache/iceberg/encryption/EncryptingFileIO.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

rdblue commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1493844182 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/BaseReader.java: ## @@ -184,25 +181,15 @@ protected InputFile getInputFile(String location) { priv

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

rdblue commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1493843963 ## core/src/main/java/org/apache/iceberg/ManifestFiles.java: ## @@ -345,34 +345,24 @@ private static ManifestFile copyManifestInternal( return writer.toManifestFile

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

rdblue commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1493843678 ## core/src/main/java/org/apache/iceberg/io/ContentCache.java: ## @@ -32,16 +32,15 @@ import org.apache.iceberg.exceptions.NotFoundException; import org.apache.iceberg

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

rdblue commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1493843026 ## core/src/main/java/org/apache/iceberg/io/ContentCache.java: ## @@ -232,80 +237,63 @@ public long getLength() { @Override public SeekableInputStream newStrea

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

rdblue commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1493842868 ## core/src/test/java/org/apache/iceberg/hadoop/TestCatalogUtilDropTable.java: ## @@ -201,6 +188,25 @@ public void shouldNotDropDataFilesIfGcNotEnabled() { .con

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

ggershinsky commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1486083697 ## api/src/main/java/org/apache/iceberg/io/FileIO.java: ## @@ -42,6 +46,30 @@ default InputFile newInputFile(String path, long length) { return newInputFile(pa

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

ggershinsky commented on PR #9592: URL: https://github.com/apache/iceberg/pull/9592#issuecomment-1938226175 Everything works with this PR. But there are two options for its integration with other PRs, lets discuss them in the call. -- This is an automated message from the Apache Git Servi

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

ggershinsky commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1483931060 ## core/src/main/java/org/apache/iceberg/ManifestFiles.java: ## @@ -345,34 +345,24 @@ private static ManifestFile copyManifestInternal( return writer.toManifes

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

ggershinsky commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1485596071 ## core/src/main/java/org/apache/iceberg/ManifestFiles.java: ## @@ -345,34 +345,24 @@ private static ManifestFile copyManifestInternal( return writer.toManifes

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

ggershinsky commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1483928229 ## api/src/main/java/org/apache/iceberg/encryption/EncryptingFileIO.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

ggershinsky commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1483931060 ## core/src/main/java/org/apache/iceberg/ManifestFiles.java: ## @@ -345,34 +345,24 @@ private static ManifestFile copyManifestInternal( return writer.toManifes

Re: [PR] API: Extend FileIO and add EncryptingFileIO. [iceberg]

ggershinsky commented on PR #9592: URL: https://github.com/apache/iceberg/pull/9592#issuecomment-1935414740 @rdblue Thanks for the PR. I am about to complete applying it to the e2e manifest/list/table encryption. So far, everything works well. I'll send updated patches next week. -- This