ggershinsky commented on code in PR #9592:
URL: https://github.com/apache/iceberg/pull/9592#discussion_r1483931060
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -345,34 +345,24 @@ private static ManifestFile copyManifestInternal(
return writer.toManifestFile();
}
- private static InputFile newInputFile(FileIO io, String path, long length) {
- boolean enabled;
-
- try {
- enabled = cachingEnabled(io);
- } catch (UnsupportedOperationException e) {
- // There is an issue reading io.properties(). Disable caching.
- enabled = false;
- }
-
- if (enabled) {
- ContentCache cache = contentCache(io);
- Preconditions.checkNotNull(
- cache,
- "ContentCache creation failed. Check that all manifest caching
configurations has valid value.");
- LOG.debug("FileIO-level cache stats: {}", CONTENT_CACHES.stats());
- return cache.tryCache(io, path, length);
+ private static InputFile newInputFile(FileIO io, ManifestFile manifest) {
+ InputFile input = io.newInputFile(manifest);
Review Comment:
Not sure I'm correct - but I thought the goal of the contentCache was to
skip creation of InputFile objects if they are requested more than once?
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -345,34 +345,24 @@ private static ManifestFile copyManifestInternal(
return writer.toManifestFile();
}
- private static InputFile newInputFile(FileIO io, String path, long length) {
- boolean enabled;
-
- try {
- enabled = cachingEnabled(io);
- } catch (UnsupportedOperationException e) {
- // There is an issue reading io.properties(). Disable caching.
- enabled = false;
- }
-
- if (enabled) {
- ContentCache cache = contentCache(io);
- Preconditions.checkNotNull(
- cache,
- "ContentCache creation failed. Check that all manifest caching
configurations has valid value.");
- LOG.debug("FileIO-level cache stats: {}", CONTENT_CACHES.stats());
- return cache.tryCache(io, path, length);
+ private static InputFile newInputFile(FileIO io, ManifestFile manifest) {
+ InputFile input = io.newInputFile(manifest);
Review Comment:
Ah, I see, it's about content caching. Retracting the question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
