rdblue commented on code in PR #9592:
URL: https://github.com/apache/iceberg/pull/9592#discussion_r1493843678
##########
core/src/main/java/org/apache/iceberg/io/ContentCache.java:
##########
@@ -32,16 +32,15 @@
import org.apache.iceberg.exceptions.NotFoundException;
import org.apache.iceberg.exceptions.ValidationException;
import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
-import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
* Class that provides file-content caching during reading.
*
- * <p>The file-content caching is initiated by calling {@link
ContentCache#tryCache(FileIO, String,
- * long)}. Given a FileIO, a file location string, and file length that is
within allowed limit,
+ * <p>The file-content caching is initiated by calling {@link
ContentCache#tryCache(InputFile)}.
Review Comment:
The changes here aren't strictly necessary, but clean up several problems I
noticed while updating the code to call `newInputFile(ManifestFile)` instead of
`newInputFile(String,long)`. The class leaked the `CacheEntry` class in its
public API (those methods are now deprecated) and had duplicate checks, overly
verbose debug logs, and odd error handling. I've simplified it a bit and made
the naming more clear for internal methods and classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
