rdblue commented on code in PR #9592:
URL: https://github.com/apache/iceberg/pull/9592#discussion_r1493842868


##########
core/src/test/java/org/apache/iceberg/hadoop/TestCatalogUtilDropTable.java:
##########
@@ -201,6 +188,25 @@ public void shouldNotDropDataFilesIfGcNotEnabled() {
         .containsAll(metadataLocations);
   }
 
+  private static FileIO createMockFileIO(FileIO wrapped) {

Review Comment:
   These tests needed the mock object to support the added `newInputFile` 
methods. Rather than continuing to change each test individually, I refactored 
to have one method that is used throughout to create the mock `FileIO`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to