rdblue commented on code in PR #9592: URL: https://github.com/apache/iceberg/pull/9592#discussion_r1493843026
########## core/src/main/java/org/apache/iceberg/io/ContentCache.java: ########## @@ -232,80 +237,63 @@ public long getLength() { @Override public SeekableInputStream newStream() { try { - // read from cache if file length is less than or equal to maximum length allowed to - // cache. - if (getLength() <= contentCache.maxContentLength()) { Review Comment: This check duplicated the one in `tryCache`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org