rdblue commented on code in PR #9592:
URL: https://github.com/apache/iceberg/pull/9592#discussion_r1493843963
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -345,34 +345,24 @@ private static ManifestFile copyManifestInternal(
return writer.toManifestFile();
}
- private static InputFile newInputFile(FileIO io, String path, long length) {
- boolean enabled;
-
- try {
- enabled = cachingEnabled(io);
- } catch (UnsupportedOperationException e) {
- // There is an issue reading io.properties(). Disable caching.
- enabled = false;
- }
-
- if (enabled) {
- ContentCache cache = contentCache(io);
- Preconditions.checkNotNull(
- cache,
- "ContentCache creation failed. Check that all manifest caching
configurations has valid value.");
- LOG.debug("FileIO-level cache stats: {}", CONTENT_CACHES.stats());
- return cache.tryCache(io, path, length);
+ private static InputFile newInputFile(FileIO io, ManifestFile manifest) {
Review Comment:
I simplified the logic here in addition to passing `ManifestFile` through to
`newInputFile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
