Re: [PR] Azure: Support multiple storage credential prefixes [iceberg]

2025-06-24 Thread via GitHub
nastra commented on code in PR #13241: URL: https://github.com/apache/iceberg/pull/13241#discussion_r2165914396 ## azure/src/integration/java/org/apache/iceberg/azure/adlsv2/PrefixedADLSClientTest.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [I] Transient AWS Connection Issues [iceberg]

2025-06-24 Thread via GitHub
dyrnq commented on issue #11412: URL: https://github.com/apache/iceberg/issues/11412#issuecomment-3003538363 @arifazmidd see need custom credentials-provider ```java .config("spark

Re: [PR] Core: Fix filed ids of partition stats file [iceberg]

2025-06-24 Thread via GitHub
ajantha-bhat commented on code in PR #13329: URL: https://github.com/apache/iceberg/pull/13329#discussion_r2165745191 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -280,6 +273,8 @@ private static Collection computeAndMergeStatsIncremental( ol

Re: [PR] Azure: Support multiple storage credential prefixes [iceberg]

2025-06-24 Thread via GitHub
nastra commented on code in PR #13241: URL: https://github.com/apache/iceberg/pull/13241#discussion_r2165902144 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/PrefixedADLSClient.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [I] Tracking issues of Iceberg Rust 0.6.0 Release (June 2025) [iceberg-rust]

2025-06-24 Thread via GitHub
liurenjie1024 commented on issue #1331: URL: https://github.com/apache/iceberg-rust/issues/1331#issuecomment-3003526965 Thanks @Xuanwo for raising this, sounds good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Azure: Support multiple storage credential prefixes [iceberg]

2025-06-24 Thread via GitHub
nastra commented on code in PR #13241: URL: https://github.com/apache/iceberg/pull/13241#discussion_r2165896403 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSOutputFile.java: ## @@ -30,6 +30,14 @@ class ADLSOutputFile extends BaseADLSFile implements OutputFile {

Re: [PR] Azure: Support multiple storage credential prefixes [iceberg]

2025-06-24 Thread via GitHub
nastra commented on code in PR #13241: URL: https://github.com/apache/iceberg/pull/13241#discussion_r2165895229 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSLocation.java: ## @@ -98,4 +101,8 @@ public String path() { public String host() { return host; }

Re: [PR] Core: Fix filed ids of partition stats file [iceberg]

2025-06-24 Thread via GitHub
lirui-apache commented on code in PR #13329: URL: https://github.com/apache/iceberg/pull/13329#discussion_r2165890885 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -280,6 +273,8 @@ private static Collection computeAndMergeStatsIncremental( ol

Re: [PR] Azure: Support multiple storage credential prefixes [iceberg]

2025-06-24 Thread via GitHub
nastra commented on code in PR #13241: URL: https://github.com/apache/iceberg/pull/13241#discussion_r2165892610 ## azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSFileIO.java: ## @@ -18,45 +18,49 @@ */ package org.apache.iceberg.azure.adlsv2; -import com.azure.core.

Re: [PR] Azure: Support multiple storage credential prefixes [iceberg]

2025-06-24 Thread via GitHub
nastra commented on code in PR #13241: URL: https://github.com/apache/iceberg/pull/13241#discussion_r2165888765 ## azure/src/integration/java/org/apache/iceberg/azure/adlsv2/PrefixedADLSClientTest.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add `hive.kerberos-service-name` configuration option (#2032) [iceberg-python]

2025-06-24 Thread via GitHub
Fokko merged PR #2141: URL: https://github.com/apache/iceberg-python/pull/2141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [I] Issue with kerberized hive metastore [iceberg-python]

2025-06-24 Thread via GitHub
Fokko closed issue #2032: Issue with kerberized hive metastore URL: https://github.com/apache/iceberg-python/issues/2032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Google BigLake Metastore Catalog issue [iceberg-python]

2025-06-24 Thread via GitHub
Fokko commented on PR #2148: URL: https://github.com/apache/iceberg-python/pull/2148#issuecomment-3000599057 Thanks @ccancellieri for raising this PR. This is something that ideally should be fixed on the BigLake side, but there is no harm to be a bit more relaxed about deserializing these

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-06-24 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2163711276 ## core/src/main/java/org/apache/iceberg/io/ReadBuilder.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Google BigLake Metastore Catalog issue [iceberg-python]

2025-06-24 Thread via GitHub
kevinjqliu commented on code in PR #2148: URL: https://github.com/apache/iceberg-python/pull/2148#discussion_r2165774244 ## pyiceberg/catalog/rest/__init__.py: ## @@ -178,12 +178,12 @@ class RegisterTableRequest(IcebergBaseModel): class ConfigResponse(IcebergBaseModel): -

Re: [PR] Spark 4.0: Migrate Iceberg Stored Procedures to Spark built-in implementations [iceberg]

2025-06-24 Thread via GitHub
aokolnychyi commented on code in PR #13106: URL: https://github.com/apache/iceberg/pull/13106#discussion_r2165379373 ## spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteManifestsProcedure.java: ## @@ -265,7 +266,7 @@ public void testRewrit

Re: [PR] Google BigLake Metastore Catalog issue [iceberg-python]

2025-06-24 Thread via GitHub
kevinjqliu commented on PR #2148: URL: https://github.com/apache/iceberg-python/pull/2148#issuecomment-3003298620 > This is something that ideally should be fixed on the BigLake side, but there is no harm to be a bit more relaxed about deserializing these messages. +1 BigLake REST cat

Re: [PR] feat: implement Primitive type Literal [iceberg-cpp]

2025-06-24 Thread via GitHub
mapleFU commented on PR #117: URL: https://github.com/apache/iceberg-cpp/pull/117#issuecomment-3003445093 Can we merge this firstly? My following patch might based on this ๐Ÿ˜‚ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Build failure with JDK 11 [iceberg]

2025-06-24 Thread via GitHub
zhztheplayer commented on issue #13380: URL: https://github.com/apache/iceberg/issues/13380#issuecomment-3003365979 > [@zhztheplayer](https://github.com/zhztheplayer) iceberg-spark-4.0 needs to be built with JDK 17+, as per [spark-ci](https://github.com/apache/iceberg/blob/main/.github/work

Re: [PR] Core: Fix filed ids of partition stats file [iceberg]

2025-06-24 Thread via GitHub
ajantha-bhat commented on code in PR #13329: URL: https://github.com/apache/iceberg/pull/13329#discussion_r2165745191 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -280,6 +273,8 @@ private static Collection computeAndMergeStatsIncremental( ol

Re: [PR] Spark-3.5, 4.0: Add unit tests for ColumnarBatchUtil [iceberg]

2025-06-24 Thread via GitHub
huaxingao merged PR #12275: URL: https://github.com/apache/iceberg/pull/12275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Google BigLake Metastore Catalog issue [iceberg-python]

2025-06-24 Thread via GitHub
kevinjqliu commented on code in PR #2148: URL: https://github.com/apache/iceberg-python/pull/2148#discussion_r2165772866 ## pyiceberg/catalog/rest/__init__.py: ## @@ -178,12 +178,12 @@ class RegisterTableRequest(IcebergBaseModel): class ConfigResponse(IcebergBaseModel): -

Re: [PR] Google BigLake Metastore Catalog issue [iceberg-python]

2025-06-24 Thread via GitHub
kevinjqliu commented on PR #2148: URL: https://github.com/apache/iceberg-python/pull/2148#issuecomment-3003322374 cc @rambleraptor @talatuyarer, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Google BigLake Metastore Catalog issue [iceberg-python]

2025-06-24 Thread via GitHub
kevinjqliu commented on code in PR #2148: URL: https://github.com/apache/iceberg-python/pull/2148#discussion_r2165779229 ## pyiceberg/catalog/rest/__init__.py: ## @@ -178,12 +178,12 @@ class RegisterTableRequest(IcebergBaseModel): class ConfigResponse(IcebergBaseModel): -

Re: [PR] Google BigLake Metastore Catalog issue [iceberg-python]

2025-06-24 Thread via GitHub
kevinjqliu commented on code in PR #2148: URL: https://github.com/apache/iceberg-python/pull/2148#discussion_r2165772866 ## pyiceberg/catalog/rest/__init__.py: ## @@ -178,12 +178,12 @@ class RegisterTableRequest(IcebergBaseModel): class ConfigResponse(IcebergBaseModel): -

Re: [PR] Optimise RowData evolution [iceberg]

2025-06-24 Thread via GitHub
aiborodin commented on code in PR #13340: URL: https://github.com/apache/iceberg/pull/13340#discussion_r2165747315 ## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java: ## @@ -220,37 +238,59 @@ SchemaInfo getSchemaInfo() { */ sta

Re: [PR] Optimise RowData evolution [iceberg]

2025-06-24 Thread via GitHub
aiborodin commented on code in PR #13340: URL: https://github.com/apache/iceberg/pull/13340#discussion_r2165747315 ## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java: ## @@ -220,37 +238,59 @@ SchemaInfo getSchemaInfo() { */ sta

Re: [PR] Optimise RowData evolution [iceberg]

2025-06-24 Thread via GitHub
aiborodin commented on code in PR #13340: URL: https://github.com/apache/iceberg/pull/13340#discussion_r2165747315 ## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java: ## @@ -220,37 +238,59 @@ SchemaInfo getSchemaInfo() { */ sta

Re: [I] Build failure with JDK 11 [iceberg]

2025-06-24 Thread via GitHub
manuzhang commented on issue #13380: URL: https://github.com/apache/iceberg/issues/13380#issuecomment-3002959289 @zhztheplayer iceberg-spark-4.0 needs to be built with JDK 17+, as per [spark-ci](https://github.com/apache/iceberg/blob/main/.github/workflows/spark-ci.yml#L79) -- This is an

[I] Build failure with JDK 11 [iceberg]

2025-06-24 Thread via GitHub
zhztheplayer opened a new issue, #13380: URL: https://github.com/apache/iceberg/issues/13380 ### Apache Iceberg version None ### Query engine None ### Please describe the bug ๐Ÿž With latest Iceberg code (6e432fcb24fd55c9024a3192b17a364623886047): O

Re: [I] Build failure with JDK 11 [iceberg]

2025-06-24 Thread via GitHub
zhztheplayer commented on issue #13380: URL: https://github.com/apache/iceberg/issues/13380#issuecomment-3002891294 @huaxingao Have you or anyone faced something similar? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Core: Fix filed ids of partition stats file [iceberg]

2025-06-24 Thread via GitHub
lirui-apache commented on code in PR #13329: URL: https://github.com/apache/iceberg/pull/13329#discussion_r2165518201 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -280,6 +273,8 @@ private static Collection computeAndMergeStatsIncremental( ol

Re: [I] Support reading table metadata with partition statistics files [iceberg-python]

2025-06-24 Thread via GitHub
smaheshwar-pltr commented on issue #2034: URL: https://github.com/apache/iceberg-python/issues/2034#issuecomment-3001043921 https://github.com/apache/iceberg-python/pull/2146 will close this -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Spark 4.0: Migrate Iceberg Stored Procedures to Spark built-in implementations [iceberg]

2025-06-24 Thread via GitHub
aokolnychyi commented on code in PR #13106: URL: https://github.com/apache/iceberg/pull/13106#discussion_r2165377232 ## spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteManifestsProcedure.java: ## @@ -265,7 +266,7 @@ public void testRewrit

Re: [I] Support Concurrency Safety Validation: Implement `validateNoNewDeletesForDataFiles` [iceberg-python]

2025-06-24 Thread via GitHub
sungwy commented on issue #1931: URL: https://github.com/apache/iceberg-python/issues/1931#issuecomment-3002159502 Hi @stevie9868 I will get this issue assigned to you! @gabeiglio accurately pointed out that this validation shares much of the underlying logic with https://github.com/apache

Re: [PR] Catalogs: Add support for unique table locations via catalog property [iceberg]

2025-06-24 Thread via GitHub
nastra commented on code in PR #12892: URL: https://github.com/apache/iceberg/pull/12892#discussion_r2164087893 ## core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java: ## @@ -685,6 +685,29 @@ public void testRenameTable() { .hasMessage("Table already exists:

Re: [I] How can I use iceberg and Minio in the Flink engine? [iceberg]

2025-06-24 Thread via GitHub
dyrnq commented on issue #8347: URL: https://github.com/apache/iceberg/issues/8347#issuecomment-3002343254 @aiwhj Hi, I found a way use CustomCredentialProvider, THAT as not using system environment variables and system parameters(-Daws.accessKeyId) for the flink cluster. IcebergRes

Re: [I] Spark configuration for amazon access key and secret key with glue catalog for apache Iceberg is not honoring [iceberg]

2025-06-24 Thread via GitHub
dyrnq commented on issue #10078: URL: https://github.com/apache/iceberg/issues/10078#issuecomment-2999875369 def create(keys: java.util.Map[String, String]): CustomCredentialProvider = { // ๆ‰“ๅฐ keys ็š„้”ฎๅ’Œๅ€ผ //keys.foreach { case (key, value) => // println(s"Key: $key, Val

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-06-24 Thread via GitHub
pvary commented on code in PR #12298: URL: https://github.com/apache/iceberg/pull/12298#discussion_r2163684249 ## data/src/main/java/org/apache/iceberg/data/RegistryBasedFileWriterFactory.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Build: Bump mypy-boto3-glue from 1.38.22 to 1.38.42 [iceberg-python]

2025-06-24 Thread via GitHub
kevinjqliu merged PR #2144: URL: https://github.com/apache/iceberg-python/pull/2144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Catalogs: Add support for unique table locations via catalog property [iceberg]

2025-06-24 Thread via GitHub
davseitsev commented on PR #12892: URL: https://github.com/apache/iceberg/pull/12892#issuecomment-2999203208 @nastra, I see you contributed a lot to catalogs, could you please review the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Flink: Supports delete orphan files in TableMaintenance [iceberg]

2025-06-24 Thread via GitHub
pvary commented on code in PR #13302: URL: https://github.com/apache/iceberg/pull/13302#discussion_r2163359522 ## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/DeleteOrphanFiles.java: ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Foundati

Re: [I] Check write snapshot compatibility [iceberg-python]

2025-06-24 Thread via GitHub
Fokko commented on issue #1678: URL: https://github.com/apache/iceberg-python/issues/1678#issuecomment-3001132470 Let me close this PR in favor of #819 since they address the same issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] we should publish rc to pypi as part of the release process [iceberg-rust]

2025-06-24 Thread via GitHub
kevinjqliu closed issue #1409: we should publish rc to pypi as part of the release process URL: https://github.com/apache/iceberg-rust/issues/1409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] validate added data files for snapshot compatibility [iceberg-python]

2025-06-24 Thread via GitHub
Fokko commented on PR #2050: URL: https://github.com/apache/iceberg-python/pull/2050#issuecomment-3001667967 This looks great @kaushiksrini, let's move this forward ๐Ÿš€ Thanks for the review @sungwy and @jayceslesar ๐Ÿ™Œ -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Spark: Fix row lineage inheritance for distributed planning [iceberg]

2025-06-24 Thread via GitHub
stevenzwu commented on code in PR #13061: URL: https://github.com/apache/iceberg/pull/13061#discussion_r2164925866 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/ManifestFileBean.java: ## @@ -46,6 +47,7 @@ public static ManifestFileBean fromManifest(ManifestF

Re: [PR] Add `hive.kerberos-service-name` configuration option (#2032) [iceberg-python]

2025-06-24 Thread via GitHub
Fokko commented on PR #2141: URL: https://github.com/apache/iceberg-python/pull/2141#issuecomment-3001705447 Thanks for adding this @gardenia ๐Ÿ™Œ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [I] Support Adding File Metadata Directly [iceberg-python]

2025-06-24 Thread via GitHub
github-actions[bot] commented on issue #1470: URL: https://github.com/apache/iceberg-python/issues/1470#issuecomment-3002225897 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity

Re: [I] Tracking issues of Iceberg Rust 0.6.0 Release (June 2025) [iceberg-rust]

2025-06-24 Thread via GitHub
kevinjqliu commented on issue #1331: URL: https://github.com/apache/iceberg-rust/issues/1331#issuecomment-3001224585 @Xuanwo go for it! Happy to help too :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Add detailed debug and warn logging to SparkMicroBatchStream [iceberg]

2025-06-24 Thread via GitHub
github-actions[bot] commented on PR #12856: URL: https://github.com/apache/iceberg/pull/12856#issuecomment-3002220022 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think thatโ€™s incorrect or this pul

Re: [I] Misleading use of LoadTableResponse in RESTTableOperations.commit() [iceberg]

2025-06-24 Thread via GitHub
github-actions[bot] closed issue #11767: Misleading use of LoadTableResponse in RESTTableOperations.commit() URL: https://github.com/apache/iceberg/issues/11767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] CatalogUtil:dropTableData method doesn't remove old Puffin files [iceberg]

2025-06-24 Thread via GitHub
github-actions[bot] commented on issue #11876: URL: https://github.com/apache/iceberg/issues/11876#issuecomment-3002219929 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Misleading use of LoadTableResponse in RESTTableOperations.commit() [iceberg]

2025-06-24 Thread via GitHub
github-actions[bot] commented on issue #11767: URL: https://github.com/apache/iceberg/issues/11767#issuecomment-3002219811 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache

Re: [PR] feat(catalog): Add TableCommit::apply to help update metadata [iceberg-rust]

2025-06-24 Thread via GitHub
liurenjie1024 merged PR #1464: URL: https://github.com/apache/iceberg-rust/pull/1464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [I] Add a method in TableCommit to apply changes to TableMetadata to create a new TableMetadata [iceberg-rust]

2025-06-24 Thread via GitHub
liurenjie1024 closed issue #1386: Add a method in TableCommit to apply changes to TableMetadata to create a new TableMetadata URL: https://github.com/apache/iceberg-rust/issues/1386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Remove JSpecify annotations from bundled-guava [iceberg]

2025-06-24 Thread via GitHub
electrum opened a new pull request, #13379: URL: https://github.com/apache/iceberg/pull/13379 These classes are not shaded and cause duplicate class conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Implement snapshot expiration [iceberg-go]

2025-06-24 Thread via GitHub
zeroshade commented on PR #401: URL: https://github.com/apache/iceberg-go/pull/401#issuecomment-3001933822 @arnaudbriche any updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] fix(catalog/rest): pass key-scope [iceberg-go]

2025-06-24 Thread via GitHub
zeroshade merged PR #464: URL: https://github.com/apache/iceberg-go/pull/464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Flink: Supports delete orphan files in TableMaintenance [iceberg]

2025-06-24 Thread via GitHub
mxm commented on code in PR #13302: URL: https://github.com/apache/iceberg/pull/13302#discussion_r2163335430 ## core/src/main/java/org/apache/iceberg/actions/FileURI.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contrib

Re: [PR] fix(catalog/rest): pass key-scope [iceberg-go]

2025-06-24 Thread via GitHub
zeroshade commented on PR #464: URL: https://github.com/apache/iceberg-go/pull/464#issuecomment-3002050405 A unit test should be sufficient, just to make sure we don't break anything in the future -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-06-24 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2163727678 ## core/src/main/java/org/apache/iceberg/io/FileAccessFactory.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[PR] Spark:3.4 Encapsulate parquet objects for Comet [iceberg]

2025-06-24 Thread via GitHub
huaxingao opened a new pull request, #13378: URL: https://github.com/apache/iceberg/pull/13378 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] fix(catalog/rest): pass key-scope [iceberg-go]

2025-06-24 Thread via GitHub
laskoviymishka commented on PR #464: URL: https://github.com/apache/iceberg-go/pull/464#issuecomment-3002046390 i can try to add a unit test, but not sure regards to e2e, from what i see profit from unit test would be relatevely low. -- This is an automated message from the Apache Git Ser

Re: [PR] Spark: Fix row lineage inheritance for distributed planning [iceberg]

2025-06-24 Thread via GitHub
stevenzwu commented on code in PR #13061: URL: https://github.com/apache/iceberg/pull/13061#discussion_r2164925866 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/ManifestFileBean.java: ## @@ -46,6 +47,7 @@ public static ManifestFileBean fromManifest(ManifestF

Re: [PR] Partition statistics metadata reading [iceberg-python]

2025-06-24 Thread via GitHub
smaheshwar-pltr commented on code in PR #2146: URL: https://github.com/apache/iceberg-python/pull/2146#discussion_r2164384458 ## pyiceberg/table/statistics.py: ## @@ -29,15 +29,24 @@ class BlobMetadata(IcebergBaseModel): properties: Optional[Dict[str, str]] = None -clas

Re: [PR] Partition statistics metadata reading [iceberg-python]

2025-06-24 Thread via GitHub
smaheshwar-pltr commented on code in PR #2146: URL: https://github.com/apache/iceberg-python/pull/2146#discussion_r2164381960 ## pyiceberg/table/statistics.py: ## @@ -29,15 +29,24 @@ class BlobMetadata(IcebergBaseModel): properties: Optional[Dict[str, str]] = None -clas

Re: [PR] Partition statistics metadata reading [iceberg-python]

2025-06-24 Thread via GitHub
smaheshwar-pltr commented on code in PR #2146: URL: https://github.com/apache/iceberg-python/pull/2146#discussion_r2164380649 ## pyiceberg/table/statistics.py: ## @@ -29,15 +29,24 @@ class BlobMetadata(IcebergBaseModel): properties: Optional[Dict[str, str]] = None -clas

Re: [I] Support Concurrency Safety Validation: Implement `validateNoNewDeletesForDataFiles` [iceberg-python]

2025-06-24 Thread via GitHub
stevie9868 commented on issue #1931: URL: https://github.com/apache/iceberg-python/issues/1931#issuecomment-3001175683 Hey @sungwy I can start working on this, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] build(deps): bump the gomod_updates group with 16 updates [iceberg-go]

2025-06-24 Thread via GitHub
zeroshade merged PR #465: URL: https://github.com/apache/iceberg-go/pull/465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] fix(catalog/rest): pass key-scope [iceberg-go]

2025-06-24 Thread via GitHub
zeroshade commented on PR #464: URL: https://github.com/apache/iceberg-go/pull/464#issuecomment-3001929127 @laskoviymishka do we have any way to add a good test for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Check write snapshot compatibility [iceberg-python]

2025-06-24 Thread via GitHub
Fokko closed issue #1678: Check write snapshot compatibility URL: https://github.com/apache/iceberg-python/issues/1678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] [WIP] feat(transaction): Add initial support for update spec in transaction API [iceberg-go]

2025-06-24 Thread via GitHub
lliangyu-lin opened a new pull request, #467: URL: https://github.com/apache/iceberg-go/pull/467 ### Description * Add support for update spec in transaction API * Reference: https://github.com/apache/iceberg-python/blob/main/pyiceberg/table/update/spec.py -- This is an automated me

[PR] Docs: Fix typo in KafkaConnect docs [iceberg]

2025-06-24 Thread via GitHub
andyhuynh3 opened a new pull request, #13377: URL: https://github.com/apache/iceberg/pull/13377 Fixes a minor typo in the KafkaConnect docs (missing `a` in `kafka_metdata_topic`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Added ExpireSnapshots Feature [iceberg-python]

2025-06-24 Thread via GitHub
ForeverAngry commented on PR #1880: URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-3001829625 > @ForeverAngry Thank you for this feature โค๏ธ > > Just one question/comment: It seems this only supports expiration time/age, and does not support other [retention

Re: [PR] Partition statistics metadata reading [iceberg-python]

2025-06-24 Thread via GitHub
Fokko commented on code in PR #2146: URL: https://github.com/apache/iceberg-python/pull/2146#discussion_r2164846313 ## tests/table/test_statistics.py: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] Partition statistics metadata reading [iceberg-python]

2025-06-24 Thread via GitHub
Fokko commented on code in PR #2146: URL: https://github.com/apache/iceberg-python/pull/2146#discussion_r2164807131 ## pyiceberg/table/statistics.py: ## @@ -29,15 +29,24 @@ class BlobMetadata(IcebergBaseModel): properties: Optional[Dict[str, str]] = None -class Statisti

Re: [PR] Add `hive.kerberos-service-name` configuration option (#2032) [iceberg-python]

2025-06-24 Thread via GitHub
kevinjqliu commented on PR #2141: URL: https://github.com/apache/iceberg-python/pull/2141#issuecomment-3001727547 Thanks @gardenia for all your help with kerberos hive :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] validate added data files for snapshot compatibility [iceberg-python]

2025-06-24 Thread via GitHub
Fokko merged PR #2050: URL: https://github.com/apache/iceberg-python/pull/2050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Row lineage fields for v3 [iceberg-python]

2025-06-24 Thread via GitHub
Fokko commented on code in PR #2129: URL: https://github.com/apache/iceberg-python/pull/2129#discussion_r2164792953 ## pyiceberg/table/snapshots.py: ## @@ -243,6 +243,12 @@ class Snapshot(IcebergBaseModel): manifest_list: str = Field(alias="manifest-list", description="Loca

Re: [PR] Row lineage fields for v3 [iceberg-python]

2025-06-24 Thread via GitHub
Fokko commented on code in PR #2129: URL: https://github.com/apache/iceberg-python/pull/2129#discussion_r2164783274 ## pyiceberg/table/metadata.py: ## @@ -552,6 +552,9 @@ def construct_refs(cls, table_metadata: TableMetadata) -> TableMetadata: next_row_id: Optional[int] =

Re: [I] Support Concurrency Safety Validation: Implement `validateAddedDataFiles` [iceberg-python]

2025-06-24 Thread via GitHub
Fokko closed issue #1929: Support Concurrency Safety Validation: Implement `validateAddedDataFiles` URL: https://github.com/apache/iceberg-python/issues/1929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] feat: delete orphaned files [iceberg-python]

2025-06-24 Thread via GitHub
Fokko commented on PR #1958: URL: https://github.com/apache/iceberg-python/pull/1958#issuecomment-3000800671 @jayceslesar I believe the merge-on-read delete files (positional deletes, equality deletes, and deletion vectors) are returned by the all-files. The only part that's missing is the

Re: [PR] Fix projected fields predicate evaluation [iceberg-python]

2025-06-24 Thread via GitHub
Fokko commented on code in PR #2029: URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2164195332 ## pyiceberg/expressions/visitors.py: ## @@ -894,12 +895,17 @@ def visit_unbound_predicate(self, predicate: UnboundPredicate[L]) -> BooleanExpr def visit_b

Re: [PR] Further refactor Parquet readers for v2 support [iceberg]

2025-06-24 Thread via GitHub
RussellSpitzer commented on PR #13290: URL: https://github.com/apache/iceberg/pull/13290#issuecomment-3001295897 @huaxingao and @wypoon do y'all have any other comment on this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Add unit tests for ColumnarBatchUtil using mocking [iceberg]

2025-06-24 Thread via GitHub
huaxingao closed issue #12054: Add unit tests for ColumnarBatchUtil using mocking URL: https://github.com/apache/iceberg/issues/12054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Added ExpireSnapshots Feature [iceberg-python]

2025-06-24 Thread via GitHub
greenlaw commented on PR #1880: URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-3001581046 @ForeverAngry Thank you for this feature โค๏ธ Just one question/comment: It seems this only supports expiration time/age, and does not support other [retention policies]

Re: [PR] Core: Fix filed ids of partition stats file [iceberg]

2025-06-24 Thread via GitHub
pvary commented on code in PR #13329: URL: https://github.com/apache/iceberg/pull/13329#discussion_r2163442630 ## core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java: ## @@ -280,6 +273,8 @@ private static Collection computeAndMergeStatsIncremental( oldStats.

Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

2025-06-24 Thread via GitHub
pvary commented on PR #12298: URL: https://github.com/apache/iceberg/pull/12298#issuecomment-3000257013 > Let's say we want to add support for Vortex file format. Here are the steps needed after this effort > > [api] add vortex to FileFormat enum > [vortex] implement VortexFileAcce

Re: [PR] validate added data files for snapshot compatibility [iceberg-python]

2025-06-24 Thread via GitHub
jayceslesar commented on code in PR #2050: URL: https://github.com/apache/iceberg-python/pull/2050#discussion_r2164660804 ## pyiceberg/table/update/validate.py: ## @@ -150,3 +151,54 @@ def _validate_deleted_data_files( if any(conflicting_entries): conflicting_snaps

Re: [I] Support Concurrency Safety Validation: Implement `validateNoNewDeletesForDataFiles` [iceberg-python]

2025-06-24 Thread via GitHub
Fokko commented on issue #1931: URL: https://github.com/apache/iceberg-python/issues/1931#issuecomment-3001463962 @stevie9868 Sure thing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Spark 4.0: Migrate Iceberg Stored Procedures to Spark built-in implementations [iceberg]

2025-06-24 Thread via GitHub
szehon-ho commented on code in PR #13106: URL: https://github.com/apache/iceberg/pull/13106#discussion_r2164639191 ## spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteManifestsProcedure.java: ## @@ -265,7 +266,7 @@ public void testRewriteS

Re: [PR] Flink: Supports delete orphan files in TableMaintenance [iceberg]

2025-06-24 Thread via GitHub
pvary commented on code in PR #13302: URL: https://github.com/apache/iceberg/pull/13302#discussion_r2163361147 ## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TableReader.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Added catalog initialization at kafka connector start [iceberg]

2025-06-24 Thread via GitHub
Claudenw commented on PR #13357: URL: https://github.com/apache/iceberg/pull/13357#issuecomment-3001179448 This is not a fix for tje race condition in JdbcCatalog. It is a fix to avoid the problem in other connectors. It also provides the connector the opportunity to do expensive init

Re: [PR] Build: Apply spotless for scala code [iceberg]

2025-06-24 Thread via GitHub
szehon-ho commented on code in PR #8023: URL: https://github.com/apache/iceberg/pull/8023#discussion_r2164573709 ## .baseline/scala/.scala212fmt.conf: ## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] Further refactor Parquet readers for v2 support [iceberg]

2025-06-24 Thread via GitHub
RussellSpitzer commented on code in PR #13290: URL: https://github.com/apache/iceberg/pull/13290#discussion_r2164541324 ## arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedValuesReader.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Fou

Re: [I] Publish Iceberg kafka connect runtime to Confluent hub [iceberg]

2025-06-24 Thread via GitHub
gilandose commented on issue #10745: URL: https://github.com/apache/iceberg/issues/10745#issuecomment-3001221018 example of someone doing this using github actions https://github.com/jaredpetersen/kafka-connect-arangodb/blob/master/.github/workflows/release.yaml and the maven plugin =

Re: [I] Tracking issues of Iceberg Rust 0.6.0 Release (June 2025) [iceberg-rust]

2025-06-24 Thread via GitHub
Xuanwo commented on issue #1331: URL: https://github.com/apache/iceberg-rust/issues/1331#issuecomment-3001006173 I believe it's time for us to start preparing the next release. If there is no other people interested, I'm willing to help run this release. -- This is an automated message fr

Re: [PR] Core: Use Shared HttpClientContext to Persist "was-retried" Attribute [iceberg]

2025-06-24 Thread via GitHub
nastra commented on PR #13339: URL: https://github.com/apache/iceberg/pull/13339#issuecomment-3000635478 given that the `was-retried` flag is being removed in https://github.com/apache/iceberg/pull/13352 is this PR still needed? -- This is an automated message from the Apache Git Service.

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-06-24 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2163712626 ## api/src/main/java/org/apache/iceberg/io/FileReader.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

Re: [PR] Core, Data: File Format API interfaces [iceberg]

2025-06-24 Thread via GitHub
pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2163713945 ## core/src/main/java/org/apache/iceberg/io/FileAccessFactory.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

  1   2   >