szehon-ho commented on code in PR #8023: URL: https://github.com/apache/iceberg/pull/8023#discussion_r2164573709
########## .baseline/scala/.scala212fmt.conf: ########## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +version = 3.9.7 + +align = none Review Comment: for learning, why do we deviate for [Imports] ########## spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CallExec.scala: ########## @@ -25,10 +24,8 @@ import org.apache.spark.sql.catalyst.util.truncatedString import org.apache.spark.sql.connector.iceberg.catalog.Procedure import scala.collection.compat.immutable.ArraySeq -case class CallExec( - output: Seq[Attribute], - procedure: Procedure, - input: InternalRow) extends LeafV2CommandExec { +case class CallExec(output: Seq[Attribute], procedure: Procedure, input: InternalRow) Review Comment: nit: can we keep the old one to be more like Spark and be more readable (or does it violate scalafmt because of maxColumns?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
