ajantha-bhat commented on code in PR #13329:
URL: https://github.com/apache/iceberg/pull/13329#discussion_r2165745191
##########
core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java:
##########
@@ -280,6 +273,8 @@ private static Collection<PartitionStats>
computeAndMergeStatsIncremental(
oldStats.forEach(
partitionStats ->
statsMap.put(partitionStats.specId(),
partitionStats.partition(), partitionStats));
+ } catch (IllegalArgumentException | IllegalStateException exception) {
Review Comment:
> But I wonder what our messages will be to users of the
readPartitionStatsFile API in 1.10.0. Should they also treat any exception as
invalid file and re-generate the stats? If that's the case, then I think we
don't even need the InvalidStatsFileException class because it's essentially
same as Exception.
`InvalidStatsFileException` is for the callers of
`computeAndMergeStatsIncremental` to know that it needs to be a fallback when
old stats cannot be read. I didn't fallback on any exception for
`computeAndMergeStatsIncremental` is because, if manifest reading failed for
network issues, it can be retired and can succeed the incremental compute after
network is repaired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
