stevenzwu commented on code in PR #13061:
URL: https://github.com/apache/iceberg/pull/13061#discussion_r2164925866
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/ManifestFileBean.java:
##########
@@ -46,6 +47,7 @@ public static ManifestFileBean fromManifest(ManifestFile
manifest) {
bean.setAddedSnapshotId(manifest.snapshotId());
bean.setContent(manifest.content().id());
bean.setSequenceNumber(manifest.sequenceNumber());
+ bean.setFirstRowId(manifest.firstRowId());
Review Comment:
I understand using bean for serialization in distributed planning. what's
the reason for using `ManifestFileBean` in the `BaseSparkAction`? that seems
to be the only place using `ManifestFileBean.ENCODER`.
BTW, this PR seems good as it is. The above discussion on bean usage in
`BaseSparkAction` can be tackled separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
