ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-3001829625

   > @ForeverAngry  Thank you for this feature ❤️   
   > 
   > Just one question/comment:  It seems this only supports expiration 
time/age, and does not support other [retention 
policies](https://iceberg.apache.org/docs/1.9.1/java-api-quickstart/#updating-retention-properties).
 For example, the Java API's ExpireSnapshots supports 
[retainLast](https://iceberg.apache.org/javadoc/0.12.0/org/apache/iceberg/ExpireSnapshots.html#retainLast(int)),
 and ManageSnapshots supports 
[setMinSnapshotsToKeep](https://iceberg.apache.org/javadoc/0.14.0/org/apache/iceberg/ManageSnapshots.html#setMinSnapshotsToKeep(java.lang.String,int)).
  Any plans to add support for these features, by chance?
   
   Yeah, those slipped my mind when I originally did it. I'd be happy to 
implement those. :)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to