kevinjqliu commented on code in PR #2148: URL: https://github.com/apache/iceberg-python/pull/2148#discussion_r2165779229
########## pyiceberg/catalog/rest/__init__.py: ########## @@ -178,12 +178,12 @@ class RegisterTableRequest(IcebergBaseModel): class ConfigResponse(IcebergBaseModel): - defaults: Properties = Field() - overrides: Properties = Field() + defaults: Optional[Properties] = Field(default_factory=dict) + overrides: Optional[Properties] = Field(default_factory=dict) class ListNamespaceResponse(IcebergBaseModel): - namespaces: List[Identifier] = Field() + namespaces: Optional[List[Identifier]] = Field(default_factory=list) Review Comment: this ones odd, i think we should revert this change. The listNamespace response should return an empty `namespaces` list https://github.com/apache/iceberg/blob/b7154119f97870608429d5a9950aaaad6d2a0276/open-api/rest-catalog-open-api.yaml#L3967-L3976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
