liurenjie1024 commented on issue #1155:
URL: https://github.com/apache/iceberg-rust/issues/1155#issuecomment-2834139867
> I believe there’s still value in maintaining an `iceberg-cli` integration
separate from `iceberg-playground`or `iceberg-explorer`, which seem geared
toward querying with
Xuanwo commented on code in PR #12598:
URL: https://github.com/apache/iceberg/pull/12598#discussion_r2062984701
##
format/spec.md:
##
@@ -1473,7 +1473,10 @@ The following table describes the possible values for
the some of the field with
### Table Metadata and Snapshots
-T
liurenjie1024 commented on PR #1244:
URL: https://github.com/apache/iceberg-rust/pull/1244#issuecomment-2834135614
cc @Xuanwo @Fokko @sdd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
liurenjie1024 commented on PR #1263:
URL: https://github.com/apache/iceberg-rust/pull/1263#issuecomment-2834134859
cc @Xuanwo @sdd @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Fokko commented on PR #12911:
URL: https://github.com/apache/iceberg/pull/12911#issuecomment-2834129807
@ajantha-bhat Thanks, and I think that's the logical thing to do. I would
reason that folks would ctrl+f on Nanosecond timestamps (that's how we call
them in the spec), and not find anyth
Fokko merged PR #12911:
URL: https://github.com/apache/iceberg/pull/12911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
ajantha-bhat commented on PR #12911:
URL: https://github.com/apache/iceberg/pull/12911#issuecomment-2834124429
Thanks for the review guys. I have accepted the suggestions. I just followed
the titles from the commit initially.
--
This is an automated message from the Apache Git Service.
T
Fokko commented on code in PR #12911:
URL: https://github.com/apache/iceberg/pull/12911#discussion_r2062969979
##
site/docs/releases.md:
##
@@ -69,6 +69,81 @@ To add a dependency on Iceberg in Maven, add the following
to your `pom.xml`:
```
+### 1.9.0 release
+
+Apache Ice
nastra commented on code in PR #12911:
URL: https://github.com/apache/iceberg/pull/12911#discussion_r2062968665
##
site/docs/releases.md:
##
@@ -69,6 +69,81 @@ To add a dependency on Iceberg in Maven, add the following
to your `pom.xml`:
```
+### 1.9.0 release
+
+Apache Ic
nastra merged PR #12906:
URL: https://github.com/apache/iceberg/pull/12906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
jbonofre commented on PR #12898:
URL: https://github.com/apache/iceberg/pull/12898#issuecomment-2834104130
@Fokko my pleasure 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
nastra merged PR #12907:
URL: https://github.com/apache/iceberg/pull/12907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko commented on PR #12898:
URL: https://github.com/apache/iceberg/pull/12898#issuecomment-2834102488
Thanks @jbonofre and @manuzhang 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Fokko merged PR #12898:
URL: https://github.com/apache/iceberg/pull/12898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
pvary commented on PR #12899:
URL: https://github.com/apache/iceberg/pull/12899#issuecomment-2834099168
@morhidi: is this a clean backport?
Please help future reviewers by starting if a backport is clean, or
highlight the required changes.
Thanks, Peter
--
This is an automa
Fokko merged PR #12848:
URL: https://github.com/apache/iceberg/pull/12848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
zhangbutao commented on issue #12878:
URL: https://github.com/apache/iceberg/issues/12878#issuecomment-2834067259
Refer to this Doc:
https://spark.apache.org/docs/3.5.1/sql-data-sources-hive-tables.html#interacting-with-different-versions-of-hive-metastore
This can let Spark work with Hiv
ajantha-bhat opened a new pull request, #12911:
URL: https://github.com/apache/iceberg/pull/12911
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
ebyhr commented on code in PR #12909:
URL: https://github.com/apache/iceberg/pull/12909#discussion_r2062933602
##
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##
@@ -563,7 +556,7 @@ private static MetadataUpdate readRemoveSnapshots(JsonNode
node) {
Meta
nastra merged PR #12904:
URL: https://github.com/apache/iceberg/pull/12904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra merged PR #12902:
URL: https://github.com/apache/iceberg/pull/12902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on code in PR #12909:
URL: https://github.com/apache/iceberg/pull/12909#discussion_r2062931127
##
.palantir/revapi.yml:
##
@@ -1178,6 +1178,9 @@ acceptedBreaks:
new: "class org.apache.iceberg.Metrics"
justification: "Java serialization across versi
Xuanwo opened a new issue, #1270:
URL: https://github.com/apache/iceberg-rust/issues/1270
Hi team, just curious, what's the recommended way to test rest
catalog changes?
For example, iceberg provides rest docker for local setup:
https://github.com/databricks/iceberg-rest-im
ajantha-bhat commented on issue #10106:
URL: https://github.com/apache/iceberg/issues/10106#issuecomment-2833946109
Not stale
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pan3793 commented on issue #12878:
URL: https://github.com/apache/iceberg/issues/12878#issuecomment-2833913144
The corresponding API was deleted in HIVE-26537
(https://github.com/apache/hive/pull/3599), while Spark 3.3-3.5 use Hive 2.3.9,
Spark 4.0 uses Hive 2.3.10, as Hive 2.3 is marked EO
manuzhang commented on PR #12714:
URL: https://github.com/apache/iceberg/pull/12714#issuecomment-2833883707
@nastra can you take a look? I'm seeing this flaky test quite often now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
manuzhang commented on PR #12692:
URL: https://github.com/apache/iceberg/pull/12692#issuecomment-2833879096
I add this to 1.10.0, since we are targeting removing deprecated APIs in
1.10.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
manuzhang closed pull request #11737: Spark 3.5: Add ignore-invalid-options to
RewriteDataFilesSparkAction and RewritePositionDeleteFilesSparkAction
URL: https://github.com/apache/iceberg/pull/11737
--
This is an automated message from the Apache Git Service.
To respond to the message, please
XBaith commented on issue #12908:
URL: https://github.com/apache/iceberg/issues/12908#issuecomment-2833832130
Hi @manuzhang , let me handle this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
manuzhang opened a new pull request, #12909:
URL: https://github.com/apache/iceberg/pull/12909
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
manuzhang opened a new issue, #12908:
URL: https://github.com/apache/iceberg/issues/12908
### Feature Request / Improvement
Currently, Spark SQL configurations for Iceberg (e.g.
`spark.sql.iceberg.vectorization.enabled`) as in
https://github.com/apache/iceberg/blob/main/spark/v3.5/sp
manuzhang commented on issue #12883:
URL: https://github.com/apache/iceberg/issues/12883#issuecomment-2833771997
@RussellSpitzer Do you have any pointers to previous discussion? I've seen
requests for help recovering a table with corrupted metadata / data files on
slack as well.
--
This
manuzhang closed issue #10116: Fix broken doc links of released versions
URL: https://github.com/apache/iceberg/issues/10116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
manuzhang commented on PR #12163:
URL: https://github.com/apache/iceberg/pull/12163#issuecomment-2833769856
@cornelcreanga are you still interested in contributing this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
github-actions[bot] commented on PR #12604:
URL: https://github.com/apache/iceberg/pull/12604#issuecomment-2833718514
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] closed issue #1227: [feat] `add_files` support parquet
files with field ids
URL: https://github.com/apache/iceberg-python/issues/1227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on issue #1227:
URL:
https://github.com/apache/iceberg-python/issues/1227#issuecomment-2833720694
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the A
github-actions[bot] closed pull request #12497: Spark: Add some tests for
variant fixup
URL: https://github.com/apache/iceberg/pull/12497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] closed pull request #12163: Update documentation / add
missing Iceberg table read properties
URL: https://github.com/apache/iceberg/pull/12163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
github-actions[bot] commented on PR #12163:
URL: https://github.com/apache/iceberg/pull/12163#issuecomment-2833718440
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] commented on PR #12497:
URL: https://github.com/apache/iceberg/pull/12497#issuecomment-2833718495
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] commented on issue #11318:
URL: https://github.com/apache/iceberg/issues/11318#issuecomment-2833718355
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache
github-actions[bot] commented on PR #12635:
URL: https://github.com/apache/iceberg/pull/12635#issuecomment-2833718542
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] closed pull request #12604: ORC: Implement initial default
values for readers
URL: https://github.com/apache/iceberg/pull/12604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
github-actions[bot] closed pull request #12296: Add properties support for
HadoopTables.load() (#12251)
URL: https://github.com/apache/iceberg/pull/12296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on PR #12296:
URL: https://github.com/apache/iceberg/pull/12296#issuecomment-2833718469
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] closed pull request #12119: Kafka Connect: Add kerberos
authentication option
URL: https://github.com/apache/iceberg/pull/12119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
github-actions[bot] commented on PR #12119:
URL: https://github.com/apache/iceberg/pull/12119#issuecomment-2833718422
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] closed issue #11318: Tabular sink connector not working
with azure event hub (kaka head)
URL: https://github.com/apache/iceberg/issues/11318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
github-actions[bot] commented on issue #10116:
URL: https://github.com/apache/iceberg/issues/10116#issuecomment-2833718285
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] commented on issue #10147:
URL: https://github.com/apache/iceberg/issues/10147#issuecomment-2833718304
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] commented on PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#issuecomment-2833718246
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
dentiny commented on PR #1266:
URL: https://github.com/apache/iceberg-rust/pull/1266#issuecomment-2833715169
Hi team, just curious, do we have a way to unit test rest catalog changes?
For example, iceberg provides rest docker for local setup:
https://github.com/databricks/iceberg-rest-ima
lliangyu-lin opened a new issue, #407:
URL: https://github.com/apache/iceberg-go/issues/407
### Apache Iceberg version
main (development)
### Please describe the bug 🐞
Current Glue catalog [create table
implementation](https://github.com/apache/iceberg-go/blob/main/catal
rdblue commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2062733967
##
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantWriters.java:
##
@@ -104,6 +137,11 @@ public class TestVariantWriters {
Variant.of(EMPTY_METADA
emkornfield commented on code in PR #12598:
URL: https://github.com/apache/iceberg/pull/12598#discussion_r2062731626
##
format/spec.md:
##
@@ -1473,7 +1473,10 @@ The following table describes the possible values for
the some of the field with
### Table Metadata and Snapshots
rdblue commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2062717955
##
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantWriters.java:
##
@@ -104,6 +137,11 @@ public class TestVariantWriters {
Variant.of(EMPTY_METADA
rdblue commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2062717890
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantWriters.java:
##
@@ -98,6 +99,16 @@ static ParquetValueWriter objects(
builder.build());
rdblue commented on code in PR #12847:
URL: https://github.com/apache/iceberg/pull/12847#discussion_r2062716521
##
parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantWriters.java:
##
@@ -360,6 +371,55 @@ public void setColumnStore(ColumnWriteStore columnStore) {
coderfender commented on PR #12901:
URL: https://github.com/apache/iceberg/pull/12901#issuecomment-2833593071
@nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
morhidi commented on PR #12899:
URL: https://github.com/apache/iceberg/pull/12899#issuecomment-2833552344
@stevenzwu or @pvary could you please check and merge this backport?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Xuanwo merged PR #1269:
URL: https://github.com/apache/iceberg-rust/pull/1269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
dependabot[bot] commented on PR #1268:
URL: https://github.com/apache/iceberg-rust/pull/1268#issuecomment-2833551470
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependen
Xuanwo closed pull request #1268: chore(deps): Bump roaring from `9496afe` to
`a015529`
URL: https://github.com/apache/iceberg-rust/pull/1268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Xuanwo commented on PR #1269:
URL: https://github.com/apache/iceberg-rust/pull/1269#issuecomment-2833551350
Thank ypu @Fokko for the review😋
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
gfee-home commented on issue #1234:
URL: https://github.com/apache/iceberg-rust/issues/1234#issuecomment-2833533706
thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
mrcnc commented on issue #1155:
URL: https://github.com/apache/iceberg-rust/issues/1155#issuecomment-2833520400
I believe there’s still value in maintaining an `iceberg-cli` integration
separate from `iceberg-playground`or `iceberg-explorer`, which seem geared
toward querying with SQL via D
jayceslesar commented on code in PR #1935:
URL: https://github.com/apache/iceberg-python/pull/1935#discussion_r2062664770
##
pyiceberg/table/update/validate.py:
##
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
jayceslesar commented on code in PR #1935:
URL: https://github.com/apache/iceberg-python/pull/1935#discussion_r2062664715
##
tests/table/test_validate.py:
##
@@ -0,0 +1,88 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.
jayceslesar commented on code in PR #1935:
URL: https://github.com/apache/iceberg-python/pull/1935#discussion_r2062661776
##
pyiceberg/table/update/validate.py:
##
@@ -0,0 +1,71 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
RussellSpitzer commented on issue #12883:
URL: https://github.com/apache/iceberg/issues/12883#issuecomment-2833456349
> It looks we can remove corrupted files after
[#12861](https://github.com/apache/iceberg/pull/12861). Please correct me if
I'm mistaken. [@RussellSpitzer](https://github.co
lawofcycles commented on PR #12544:
URL: https://github.com/apache/iceberg/pull/12544#issuecomment-2833495607
Hi @jackye1995 @geruh when you have a moment, could you please review this
PR?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, p
Xuanwo commented on code in PR #12598:
URL: https://github.com/apache/iceberg/pull/12598#discussion_r2062591347
##
format/spec.md:
##
@@ -1473,7 +1473,10 @@ The following table describes the possible values for
the some of the field with
### Table Metadata and Snapshots
-T
Xuanwo opened a new pull request, #1269:
URL: https://github.com/apache/iceberg-rust/pull/1269
## Which issue does this PR close?
- Closes https://github.com/apache/iceberg-rust/pull/1268
## What changes are included in this PR?
## Are these changes tested
liurenjie1024 merged PR #1265:
URL: https://github.com/apache/iceberg-rust/pull/1265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
dependabot[bot] opened a new pull request, #1268:
URL: https://github.com/apache/iceberg-rust/pull/1268
Bumps [roaring](https://github.com/RoaringBitmap/roaring-rs) from `9496afe`
to `a015529`.
Commits
https://github.com/RoaringBitmap/roaring-rs/commit/a0155299105f32b65ddf3c6d7
Xuanwo opened a new pull request, #1266:
URL: https://github.com/apache/iceberg-rust/pull/1266
## Which issue does this PR close?
- Closes https://github.com/apache/iceberg-rust/issues/1234
## What changes are included in this PR?
Allow deserialize error with empt
dentiny commented on PR #1265:
URL: https://github.com/apache/iceberg-rust/pull/1265#issuecomment-2833377445
The unit test CI gets cancelled somehow, don't see obvious error on my end;
remerge main branch to trigger rerun. :(
--
This is an automated message from the Apache Git Service.
To
Xuanwo commented on code in PR #1267:
URL: https://github.com/apache/iceberg-rust/pull/1267#discussion_r2062578139
##
CONTRIBUTING.md:
##
@@ -107,6 +107,21 @@ For MacOS users, you can install [OrbStack as a docker
alternative](docs/contrib
For podman, refer to [Using Podman
liurenjie1024 merged PR #1266:
URL: https://github.com/apache/iceberg-rust/pull/1266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
Xuanwo commented on issue #1038:
URL: https://github.com/apache/iceberg-rust/issues/1038#issuecomment-2833355025
Perhaps we can close this issue now that we've reached a consensus.
Additional types of errors can be discussed on a case-by-case basis.
cc @liurenjie1024 @dentiny
--
T
liurenjie1024 closed issue #1234: restcatalog::namespace_exists always fails
URL: https://github.com/apache/iceberg-rust/issues/1234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
liurenjie1024 closed issue #1234: restcatalog::namespace_exists always fails
URL: https://github.com/apache/iceberg-rust/issues/1234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
xxchan commented on issue #803:
URL: https://github.com/apache/iceberg-rust/issues/803#issuecomment-2833351687
> provides better DX like a vscode extension
([marketplace.visualstudio.com/items?itemName=mitsuhiko.insta](https://marketplace.visualstudio.com/items?itemName=mitsuhiko.insta)).
dentiny opened a new pull request, #1267:
URL: https://github.com/apache/iceberg-rust/pull/1267
## What changes are included in this PR?
This PR adds linting and formatting logic into precommit hook, the code is
copied from CI setup to keep consistency.
https://github.com/apache/i
lidavidm commented on code in PR #88:
URL: https://github.com/apache/iceberg-cpp/pull/88#discussion_r2062574097
##
src/iceberg/file_reader.h:
##
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See
Xuanwo commented on issue #1234:
URL: https://github.com/apache/iceberg-rust/issues/1234#issuecomment-2833348081
Should be fixed by https://github.com/apache/iceberg-rust/pull/1266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
liurenjie1024 commented on PR #1265:
URL: https://github.com/apache/iceberg-rust/pull/1265#issuecomment-2833346499
> Some tests failed for:
>
> ```rust
>
catalog::tests::test_create_deeply_nested_namespace_throws_error_if_intermediate_namespace_doesnt_exist
stdout
> t
Xuanwo commented on issue #1234:
URL: https://github.com/apache/iceberg-rust/issues/1234#issuecomment-2833345165
After deeply investigating this issue, I've found that the real problem
isn't related to how we handle the status code.
We already allow both `204` and `200`:
http
Xuanwo commented on issue #803:
URL: https://github.com/apache/iceberg-rust/issues/803#issuecomment-288594
> We already have `expect-test` snapshot tests, as mentioned above, why not
just use it? (To clarify, I'm fine with switching if people prefer.)
`mitsuhiko/insta` is used mor
dentiny commented on PR #1265:
URL: https://github.com/apache/iceberg-rust/pull/1265#issuecomment-288637
> Some tests failed for:
Thanks for the patience! I should get them fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
xxchan commented on issue #803:
URL: https://github.com/apache/iceberg-rust/issues/803#issuecomment-2833322157
Snapshot testing should also be perfectly suitable for test like this (args
parsing)
https://github.com/apache/iceberg-rust/pull/1220/files#diff-cb9d997d5104f8406186a80782bdc7f9bde
xxchan commented on issue #803:
URL: https://github.com/apache/iceberg-rust/issues/803#issuecomment-2833320825
We already have `expect-test` snapshot tests, as mentioned above, why not
just use it? (To clarify, I'm fine with switching if people prefer.)
BTW, share a very nice blog
liurenjie1024 commented on issue #1038:
URL: https://github.com/apache/iceberg-rust/issues/1038#issuecomment-2833311365
> My philosophy is to add retry to read operation first.
I think it would be reasonable to do it first.
--
This is an automated message from the Apache Git Service
dependabot[bot] opened a new pull request, #406:
URL: https://github.com/apache/iceberg-go/pull/406
Bumps the gomod_updates group with 4 updates:
[github.com/Azure/azure-sdk-for-go/sdk/storage/azblob](https://github.com/Azure/azure-sdk-for-go),
[github.com/aws/aws-sdk-go-v2/service/glue](h
Xuanwo commented on issue #803:
URL: https://github.com/apache/iceberg-rust/issues/803#issuecomment-2833297837
I find this issue during reviewing
https://github.com/apache/iceberg-rust/pull/1265
Maybe we can use https://github.com/mitsuhiko/insta for better UX?
--
This is an automa
Xuanwo commented on PR #1265:
URL: https://github.com/apache/iceberg-rust/pull/1265#issuecomment-2833296718
Some tests failed for:
```rust
catalog::tests::test_create_deeply_nested_namespace_throws_error_if_intermediate_namespace_doesnt_exist
stdout
thread
'catalog::
dentiny commented on issue #1038:
URL: https://github.com/apache/iceberg-rust/issues/1038#issuecomment-2833285127
> I have concerns about adding retrying layer at catalog. Iceberg catalog is
different from io layer like opendal or filesystem, whose operations are
typically idempotent. For e
liurenjie1024 commented on issue #1038:
URL: https://github.com/apache/iceberg-rust/issues/1038#issuecomment-2833282611
> > Maybe you would like to start working on this?
>
> Sounds good! Let me start an issue to track.
>
> One thing would like to hear your suggestion is, there'
dentiny opened a new pull request, #1265:
URL: https://github.com/apache/iceberg-rust/pull/1265
## Which issue does this PR close?
Related to https://github.com/apache/iceberg-rust/issues/1249
## What changes are included in this PR?
As discussed in
https://github.com/ap
1 - 100 of 106 matches
Mail list logo
