Xuanwo commented on code in PR #12598: URL: https://github.com/apache/iceberg/pull/12598#discussion_r2062591347
########## format/spec.md: ########## @@ -1473,7 +1473,10 @@ The following table describes the possible values for the some of the field with ### Table Metadata and Snapshots -Table metadata is serialized as a JSON object according to the following table. Snapshots are not serialized separately. Instead, they are stored in the table metadata JSON. +Table metadata is serialized as a JSON object according to the following table. Snapshots are not serialized separately. Instead, they are stored in the table metadata JSON. + +A metadata JSON file must end in `.metadata.json`. A metadata JSON file may be compressed with [GZIP](https://datatracker.ietf.org/doc/html/rfc1952). A GZIP compressed file must end with `.gz.metadata.json`. Review Comment: Hi, I have two concerns about this change: - `.gz.metadata.json` is quite uncommon and can't be read by most existing tools. Would it be better to support `.metadata.json.gz` and treat `.gz.metadata.json` as legacy for backward compatibility? - `gzip` is becoming increasingly outdated due to its lack of support for modern CPUs. New algorithms like `zstd` are gaining popularity, so should we consider allowing users to use `.metadata.json.zst` as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
