Xuanwo commented on issue #803: URL: https://github.com/apache/iceberg-rust/issues/803#issuecomment-2833338594
> We already have `expect-test` snapshot tests, as mentioned above, why not just use it? (To clarify, I'm fine with switching if people prefer.) `mitsuhiko/insta` is used more widely and provides better DX like a vscode extension (https://marketplace.visualstudio.com/items?itemName=mitsuhiko.insta). > BTW, share a very nice blog about snapshot testing here: https://matklad.github.io/2025/04/15/underusing-snapshot-testing.html Thanks a lot for the share! > Snapshot testing should also be perfectly suitable for test like this (args parsing) https://github.com/apache/iceberg-rust/pull/1220/files#diff-cb9d997d5104f8406186a80782bdc7f9bde4426ec307b73ce710d94bfae5ac5aR2270-R2295 Agreed. It should be good for us to migrate tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
