RussellSpitzer commented on code in PR #12781:
URL: https://github.com/apache/iceberg/pull/12781#discussion_r2041032813
##
format/spec.md:
##
@@ -450,21 +448,24 @@ Within `added1`, the first added manifest, each data
file's `first_row_id` follo
The `first_row_id` of the EXIS
RussellSpitzer commented on PR #12748:
URL: https://github.com/apache/iceberg/pull/12748#issuecomment-2799780943
Don't we need it to be an int[] for the tests that use JUnit annotations not
expecting a List?
--
This is an automated message from the Apache Git Service.
To respond to the me
Xuanwo closed issue #1142: An iceberg cli tool
URL: https://github.com/apache/iceberg-rust/issues/1142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: i
Xuanwo merged PR #1194:
URL: https://github.com/apache/iceberg-rust/pull/1194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
ForeverAngry commented on PR #1880:
URL: https://github.com/apache/iceberg-python/pull/1880#issuecomment-2799746883
After looking at the way the action
[here](https://github.com/apache/iceberg-python/blob/15887011cb6bae9a4408eedc2824133efa3e1599/pyiceberg/table/update/__init__.py#L471)
was
pvary commented on issue #12749:
URL: https://github.com/apache/iceberg/issues/12749#issuecomment-2799684141
> I think your prs need a fix to the tests because some of the metrics are
> not the same between 13 and 15
> […](#)
Are these changes are breaking changes for users? Can
kevinjqliu commented on code in PR #1899:
URL: https://github.com/apache/iceberg-python/pull/1899#discussion_r2040916223
##
dev/Dockerfile:
##
@@ -39,20 +39,20 @@ WORKDIR ${SPARK_HOME}
# Remember to also update `tests/conftest`'s spark setting
ENV SPARK_VERSION=3.5.4
ENV ICEB
kevinjqliu commented on PR #1747:
URL: https://github.com/apache/iceberg-python/pull/1747#issuecomment-2799651827
CI's currently failing for main branch, see
https://github.com/apache/iceberg-python/pull/1899/files#r2040915222
--
This is an automated message from the Apache Git Service.
T
kevinjqliu commented on code in PR #1899:
URL: https://github.com/apache/iceberg-python/pull/1899#discussion_r2040915222
##
dev/Dockerfile:
##
@@ -39,20 +39,20 @@ WORKDIR ${SPARK_HOME}
# Remember to also update `tests/conftest`'s spark setting
ENV SPARK_VERSION=3.5.4
ENV ICEB
lawofcycles commented on PR #12544:
URL: https://github.com/apache/iceberg/pull/12544#issuecomment-2799590136
I ran the integration tests in my environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] opened a new pull request, #12789:
URL: https://github.com/apache/iceberg/pull/12789
Bumps `guava` from 33.4.6-jre to 33.4.7-jre.
Updates `com.google.guava:guava` from 33.4.6-jre to 33.4.7-jre
Release notes
Sourced from https://github.com/google/guava/releases";>c
dependabot[bot] opened a new pull request, #12785:
URL: https://github.com/apache/iceberg/pull/12785
Bumps `junit-platform` from 1.11.4 to 1.12.2.
Updates `org.junit.platform:junit-platform-suite-api` from 1.11.4 to 1.12.2
Commits
See full diff in https://github.com/junit-tea
dependabot[bot] opened a new pull request, #12788:
URL: https://github.com/apache/iceberg/pull/12788
Bumps software.amazon.awssdk:bom from 2.29.52 to 2.31.21.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=soft
dependabot[bot] opened a new pull request, #12787:
URL: https://github.com/apache/iceberg/pull/12787
Bumps `junit` from 5.11.4 to 5.12.2.
Updates `org.junit.jupiter:junit-jupiter` from 5.11.4 to 5.12.2
Release notes
Sourced from https://github.com/junit-team/junit5/releases";>org
dependabot[bot] opened a new pull request, #12786:
URL: https://github.com/apache/iceberg/pull/12786
Bumps `nessie` from 0.103.2 to 0.103.3.
Updates `org.projectnessie.nessie:nessie-client` from 0.103.2 to 0.103.3
Updates `org.projectnessie.nessie:nessie-jaxrs-testextension` from 0.
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040877247
##
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkUtil.java:
##
@@ -154,8 +154,9 @@ public static Configuration
hadoopConfCatalogOverrides(SparkSessi
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040876801
##
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##
@@ -875,7 +875,13 @@ private static void deleteManifests(FileIO io,
List manifes
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040874901
##
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/CreateChangelogViewProcedure.java:
##
@@ -246,11 +249,10 @@ private String viewName(ProcedureI
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040874901
##
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/CreateChangelogViewProcedure.java:
##
@@ -246,11 +249,10 @@ private String viewName(ProcedureI
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040867656
##
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSystemFunctionPushDownInRowLevelOperations.java:
##
@@ -260,7 +267,12 @@ privat
gty404 commented on PR #68:
URL: https://github.com/apache/iceberg-cpp/pull/68#issuecomment-2799540564
Thanks @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040867163
##
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCallStatementParser.java:
##
@@ -69,16 +70,9 @@ public static void stopSpark()
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040867000
##
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/ExtensionsTestBase.java:
##
@@ -43,7 +43,7 @@ public static void startMetastoreAndS
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040866434
##
spark/v4.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/IcebergCall.scala:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Soft
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040864208
##
spark/v4.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala:
##
@@ -105,7 +106,7 @@ object CheckViews extends (LogicalPlan
github-actions[bot] commented on PR #12071:
URL: https://github.com/apache/iceberg/pull/12071#issuecomment-2799347878
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on issue #11318:
URL: https://github.com/apache/iceberg/issues/11318#issuecomment-2799347836
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040823516
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java:
##
@@ -282,6 +282,8 @@ private void initConf(HiveConf conf, int port, boolean
direc
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040822469
##
core/src/main/java/org/apache/iceberg/MetadataColumns.java:
##
@@ -50,7 +50,7 @@ private MetadataColumns() {}
public static final int SPEC_ID_COLUMN_ID = Inte
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040818865
##
build.gradle:
##
@@ -760,6 +763,7 @@ project(':iceberg-hive-metastore') {
testImplementation project(path: ':iceberg-api', configuration:
'testArtifacts')
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040812098
##
gradle/libs.versions.toml:
##
@@ -24,6 +24,7 @@ activation = "1.1.1"
aliyun-sdk-oss = "3.10.2"
analyticsaccelerator = "1.0.0"
antlr = "4.9.3"
+antlr413 = "4.1
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040811087
##
gradle/libs.versions.toml:
##
@@ -81,6 +82,7 @@ slf4j = "2.0.17"
snowflake-jdbc = "3.23.2"
spark34 = "3.4.4"
spark35 = "3.5.5"
+spark40 = "4.0.1-SNAPSHOT"
Re
huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040810412
##
build.gradle:
##
@@ -119,6 +119,9 @@ allprojects {
repositories {
mavenCentral()
mavenLocal()
+maven {
+ url "https://repository.apache.org
hugokitano commented on issue #1202:
URL: https://github.com/apache/iceberg-rust/issues/1202#issuecomment-2799207671
> Hi [@hugokitano](https://github.com/hugokitano), seems this example uses
the map type in the wrong way.
>
> ```
> // Create the key_value field with metadata
hugokitano closed issue #1202: Unable to write Map types with ParquetWriter
URL: https://github.com/apache/iceberg-rust/issues/1202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
sullis commented on code in PR #12748:
URL: https://github.com/apache/iceberg/pull/12748#discussion_r2040777530
##
core/src/test/java/org/apache/iceberg/TestBase.java:
##
@@ -199,7 +201,7 @@ public class TestBase {
@Parameters(name = "formatVersion = {0}")
protected stat
Fokko commented on PR #68:
URL: https://github.com/apache/iceberg-cpp/pull/68#issuecomment-2799040140
@gty404 sure thing, sorry for the late reply. I was traveling. Thanks for
working on this, and thanks @lidavidm and @wgtmac for the review! 🙌
--
This is an automated message from the Apa
Fokko merged PR #68:
URL: https://github.com/apache/iceberg-cpp/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
RussellSpitzer commented on issue #12749:
URL: https://github.com/apache/iceberg/issues/12749#issuecomment-2799024718
I think your prs need a fix to the tests because some of the metrics are
not the same between 13 and 15
On Sat, Apr 12, 2025 at 9:54 AM Manu Zhang ***@***.***> wrote
zeroshade commented on code in PR #391:
URL: https://github.com/apache/iceberg-go/pull/391#discussion_r2040717112
##
table/internal/utils_test.go:
##
@@ -68,3 +70,25 @@ func TestTruncateUpperBoundBinary(t *testing.T) {
assert.Equal(t, []byte{0x01, 0x03},
internal.Trunca
Xuanwo merged PR #1203:
URL: https://github.com/apache/iceberg-rust/pull/1203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
amogh-jahagirdar commented on code in PR #12781:
URL: https://github.com/apache/iceberg/pull/12781#discussion_r2040688326
##
format/spec.md:
##
@@ -450,21 +448,24 @@ Within `added1`, the first added manifest, each data
file's `first_row_id` follo
The `first_row_id` of the EX
amogh-jahagirdar merged PR #12777:
URL: https://github.com/apache/iceberg/pull/12777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
amogh-jahagirdar commented on PR #12777:
URL: https://github.com/apache/iceberg/pull/12777#issuecomment-2798879077
Thanks for reviewing @RussellSpitzer !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
amogh-jahagirdar commented on code in PR #12777:
URL: https://github.com/apache/iceberg/pull/12777#discussion_r2040679755
##
core/src/test/java/org/apache/iceberg/TestRewriteFiles.java:
##
@@ -50,7 +50,9 @@ protected static List parameters() {
new Object[] {1, "main"},
zhjwpku commented on code in PR #58:
URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2040673571
##
test/expression_test.cc:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the
manuzhang commented on PR #12778:
URL: https://github.com/apache/iceberg/pull/12778#issuecomment-2798863720
@akhilyendluri is the UT failure related to upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
manuzhang commented on issue #12749:
URL: https://github.com/apache/iceberg/issues/12749#issuecomment-2798861989
I opened a [discussion on dev
list](https://lists.apache.org/thread/0tnnc81p6nw2kz32oz1fscvm2ztf8wtb). Please
chime in.
--
This is an automated message from the Apache Git Ser
wgtmac commented on code in PR #58:
URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2040669212
##
src/iceberg/expression.h:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the
arnaudbriche commented on PR #391:
URL: https://github.com/apache/iceberg-go/pull/391#issuecomment-2798855127
@laskoviymishka added a test that fail with previous code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
wgtmac commented on code in PR #61:
URL: https://github.com/apache/iceberg-cpp/pull/61#discussion_r2040668421
##
src/iceberg/transform.h:
##
@@ -56,16 +57,133 @@ enum class TransformType {
kVoid,
};
+/// \brief Get the relative transform name
+ICEBERG_EXPORT constexpr std:
xxchan commented on code in PR #1203:
URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040666986
##
crates/iceberg/src/spec/values.rs:
##
@@ -1726,102 +1725,53 @@ impl Literal {
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct Struct {
/// Vector
xxchan commented on code in PR #1203:
URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040667397
##
.github/workflows/ci.yml:
##
@@ -144,7 +144,7 @@ jobs:
cargo generate-lockfile -Z direct-minimal-versions -Z
minimal-versions
# Some depen
xxchan commented on code in PR #1203:
URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040666986
##
crates/iceberg/src/spec/values.rs:
##
@@ -1726,102 +1725,53 @@ impl Literal {
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct Struct {
/// Vector
mimikwang commented on code in PR #393:
URL: https://github.com/apache/iceberg-go/pull/393#discussion_r2040659395
##
table/requirements.go:
##
@@ -273,3 +279,81 @@ func (a *assertDefaultSortOrderId) Validate(meta Metadata)
error {
return nil
}
+
+// ParseRequirement
mimikwang commented on code in PR #393:
URL: https://github.com/apache/iceberg-go/pull/393#discussion_r2040659395
##
table/requirements.go:
##
@@ -273,3 +279,81 @@ func (a *assertDefaultSortOrderId) Validate(meta Metadata)
error {
return nil
}
+
+// ParseRequirement
mimikwang opened a new pull request, #393:
URL: https://github.com/apache/iceberg-go/pull/393
Added `ParseRequirement` and its string and bytes counterpart to facilitate
parsing the Requirement interface based on type.
Part of #381
--
This is an automated message from the Apache G
lawofcycles commented on PR #12544:
URL: https://github.com/apache/iceberg/pull/12544#issuecomment-2798790816
I explored adding Lake Formation Multi Dialect Views.
However, it introduce several requirements, including:
- Only IAM roles can create Data Catalog views (no other IAM en
laskoviymishka commented on PR #388:
URL: https://github.com/apache/iceberg-go/pull/388#issuecomment-2798750288
hm, the integration error in CI is not reproduceable locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
laskoviymishka commented on PR #391:
URL: https://github.com/apache/iceberg-go/pull/391#issuecomment-2798743307
Is it possible to make a repro test for this bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
laskoviymishka commented on code in PR #392:
URL: https://github.com/apache/iceberg-go/pull/392#discussion_r2040611577
##
table/updates.go:
##
@@ -25,15 +25,21 @@ import (
)
const (
- updateSpec = "add-spec"
- updateAddSchema= "add-schema"
-
yingcai-cy commented on code in PR #58:
URL: https://github.com/apache/iceberg-cpp/pull/58#discussion_r2040591689
##
src/iceberg/expression.h:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See
liurenjie1024 commented on PR #1203:
URL: https://github.com/apache/iceberg-rust/pull/1203#issuecomment-2798698081
Wait for @Xuanwo to take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
liurenjie1024 commented on code in PR #1203:
URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040593754
##
.github/workflows/ci.yml:
##
@@ -144,7 +144,7 @@ jobs:
cargo generate-lockfile -Z direct-minimal-versions -Z
minimal-versions
# Som
liurenjie1024 commented on issue #1201:
URL: https://github.com/apache/iceberg-rust/issues/1201#issuecomment-2798694339
cc @Xuanwo @Fokko Do you have ideas what's the best practice of publishing
docker images in apache projects?
--
This is an automated message from the Apache Git Service
liurenjie1024 commented on issue #1201:
URL: https://github.com/apache/iceberg-rust/issues/1201#issuecomment-2798693840
> The slowest part is actually apt update. Therefore, perhaps we can utilize
GHC docker cache instead.
This seems making things more complicated, why not just mainta
liurenjie1024 commented on code in PR #1194:
URL: https://github.com/apache/iceberg-rust/pull/1194#discussion_r2040592423
##
.github/workflows/ci.yml:
##
@@ -126,9 +126,20 @@ jobs:
- name: Test
run: cargo test --no-fail-fast --all-targets --all-features --workspa
liurenjie1024 commented on code in PR #1079:
URL: https://github.com/apache/iceberg-rust/pull/1079#discussion_r2040592314
##
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##
@@ -458,6 +459,54 @@ impl ParquetWriter {
Ok(builder)
}
+
+#[allow(dead_co
68 matches
Mail list logo
