huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040864208


##########
spark/v4.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckViews.scala:
##########
@@ -105,7 +106,7 @@ object CheckViews extends (LogicalPlan => Unit) {
   ): Unit = {
     val newCyclePath = cyclePath :+ currentViewIdent
     if (currentViewIdent == viewIdent) {
-      throw new AnalysisException(String.format("Recursive cycle in view 
detected: %s (cycle: %s)",
+      throw new IcebergAnalysisException(String.format("Recursive cycle in 
view detected: %s (cycle: %s)",

Review Comment:
   Spark 4.0 doesn't allow constructing an AnalysisException with error message 
only. We have to provide an error class. In order to get around this, I have 
added `IcebergAnalysisException`, which only needs an error message.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to