liurenjie1024 commented on code in PR #1203:
URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040593754
##########
.github/workflows/ci.yml:
##########
@@ -144,7 +144,7 @@ jobs:
cargo generate-lockfile -Z direct-minimal-versions -Z
minimal-versions
# Some dependencies don't correctly specify a minimal version for
their dependencies and will fail to build.
# So we update these transitive dependencies here.
- cargo update tap faststr metainfo linkedbytes
+ cargo update faststr metainfo linkedbytes
Review Comment:
Not related to this pr, but I don't think updating this in ci is a good
practice. If we require minimum version of some package, why not just
maintaining them specifically in our `Cargo.toml`?
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -1726,102 +1725,53 @@ impl Literal {
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct Struct {
/// Vector to store the field values
- fields: Vec<Literal>,
- /// Null bitmap
- null_bitmap: BitVec,
+ fields: Vec<Option<Literal>>,
Review Comment:
In theory, the memory used in this approach is a little larger, but I think
it's fine to do it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
