huaxingao commented on code in PR #12494: URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040823516
########## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java: ########## @@ -282,6 +282,8 @@ private void initConf(HiveConf conf, int port, boolean directSql) { // Setting this to avoid thrift exception during running Iceberg tests outside Iceberg. conf.set( HiveConf.ConfVars.HIVE_IN_TEST.varname, HiveConf.ConfVars.HIVE_IN_TEST.getDefaultValue()); + + conf.set("datanucleus.connectionPoolingType", "HikariCP"); Review Comment: Spark 4.0 removed dependency on com.jolbox:bonecp. If not set the cp type, it will default to `com.jolbox:bonecp` and we will get ``` Exception in thread "TThreadPoolServer WorkerProcess-5" java.lang.NoClassDefFoundError: com/jolbox/bonecp/BoneCPConfig at org.apache.hadoop.hive.metastore.txn.TxnHandler.setupJdbcConnectionPool(TxnHandler.java:3156) at org.apache.hadoop.hive.metastore.txn.TxnHandler.setConf(TxnHandler.java:260) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org