huaxingao commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2040818865
##########
build.gradle:
##########
@@ -760,6 +763,7 @@ project(':iceberg-hive-metastore') {
testImplementation project(path: ':iceberg-api', configuration:
'testArtifacts')
testImplementation project(path: ':iceberg-core', configuration:
'testArtifacts')
testImplementation libs.awaitility
+ testImplementation 'com.zaxxer:HikariCP:5.1.0'
Review Comment:
Spark 4.0 removed dependency on `com.jolbox:bonecp`. In
`TestHiveMetastore.java`, I explicitly set the connection pool to
`conf.set("datanucleus.connectionPoolingType", "HikariCP");`, otherwise, it
will default to ``com.jolbox:bonecp` and we will get
```
Exception in thread "TThreadPoolServer WorkerProcess-5"
java.lang.NoClassDefFoundError: com/jolbox/bonecp/BoneCPConfig
at
org.apache.hadoop.hive.metastore.txn.TxnHandler.setupJdbcConnectionPool(TxnHandler.java:3156)
at
org.apache.hadoop.hive.metastore.txn.TxnHandler.setConf(TxnHandler.java:260)
```
Since I explicitly set the connection pool to
`conf.set("datanucleus.connectionPoolingType", "HikariCP");`, we need to add
the test dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
