xxchan commented on code in PR #1203:
URL: https://github.com/apache/iceberg-rust/pull/1203#discussion_r2040666986
##########
crates/iceberg/src/spec/values.rs:
##########
@@ -1726,102 +1725,53 @@ impl Literal {
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct Struct {
/// Vector to store the field values
- fields: Vec<Literal>,
- /// Null bitmap
- null_bitmap: BitVec,
+ fields: Vec<Option<Literal>>,
Review Comment:
Option enum usually have the same memory size as the enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
