Re: [PR] Parquet: Clean up Parquet generic and internal readers [iceberg]

ajantha-bhat commented on code in PR #12102: URL: https://github.com/apache/iceberg/pull/12102#discussion_r1933395608 ## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java: ## @@ -214,10 +214,8 @@ public Optional> visit( @Override public Opti

Re: [PR] Parquet: Clean up Parquet generic and internal readers [iceberg]

ajantha-bhat commented on code in PR #12102: URL: https://github.com/apache/iceberg/pull/12102#discussion_r1933385445 ## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java: ## @@ -214,10 +214,8 @@ public Optional> visit( @Override public Opti

Re: [PR] Parquet: Clean up Parquet generic and internal readers [iceberg]

ajantha-bhat commented on code in PR #12102: URL: https://github.com/apache/iceberg/pull/12102#discussion_r1933385445 ## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java: ## @@ -214,10 +214,8 @@ public Optional> visit( @Override public Opti

Re: [PR] Parquet: Clean up Parquet generic and internal readers [iceberg]

ajantha-bhat commented on code in PR #12102: URL: https://github.com/apache/iceberg/pull/12102#discussion_r1933385445 ## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java: ## @@ -214,10 +214,8 @@ public Optional> visit( @Override public Opti

Re: [PR] Parquet: Clean up Parquet generic and internal readers [iceberg]

ajantha-bhat commented on code in PR #12102: URL: https://github.com/apache/iceberg/pull/12102#discussion_r1933383048 ## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java: ## @@ -214,10 +214,8 @@ public Optional> visit( @Override public Opti

Re: [PR] Parquet: Clean up Parquet generic and internal readers [iceberg]

ajantha-bhat commented on code in PR #12102: URL: https://github.com/apache/iceberg/pull/12102#discussion_r1933383048 ## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java: ## @@ -214,10 +214,8 @@ public Optional> visit( @Override public Opti

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1933380621 ## aws-bundle/NOTICE: ## @@ -101,3 +100,252 @@ To find the details that apply to this artifact see the accompanying LICENSE fil A list of contributors may be found

Re: [PR] Make view metadata path configurable by `write.metadata.path` [iceberg]

tomtongue commented on code in PR #12017: URL: https://github.com/apache/iceberg/pull/12017#discussion_r1933367238 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -239,6 +239,36 @@ public void completeCreateView() { assertThat(catalog().viewExists

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1933347495 ## gcp-bundle/NOTICE: ## @@ -1,5 +1,4 @@ - -Apache Iceberg +Apache Iceberg (GCP Bundle) Review Comment: I agree. -- This is an automated message from the Apa

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932837482 ## azure-bundle/NOTICE: ## @@ -1,5 +1,4 @@ - -Apache Iceberg +Apache Iceberg (Azure bundle) Review Comment: do we want to keep the empty line ? I don't see the r

Re: [PR] Core: add variant type support [iceberg]

aihuaxu commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r196931 ## core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java: ## @@ -49,6 +49,15 @@ abstract class TypeToSchema extends TypeUtil.SchemaVisitor { private static

Re: [PR] Core: add variant type support [iceberg]

aihuaxu commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r196931 ## core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java: ## @@ -49,6 +49,15 @@ abstract class TypeToSchema extends TypeUtil.SchemaVisitor { private static

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933314814 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933314992 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933315559 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933315889 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933315384 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933315120 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometConstantColumnReader.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933314241 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/ParquetReaderType.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[PR] feat: Make some REST methods public [iceberg-rust]

peasee opened a new pull request, #922: URL: https://github.com/apache/iceberg-rust/pull/922 * Makes `ErrorResponse`, `OK`, and `HttpClient` public to support escape-hatching for REST catalogs that don't 100% support the iceberg catalog response formats. I'd like to use `iceberg-rust

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933299355 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java: ## @@ -27,6 +27,10 @@ private SparkSQLProperties() {} // Controls whether vecto

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933298067 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/ParquetReaderType.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933273861 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/ParquetReaderType.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933278905 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometConstantColumnReader.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933280739 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933281323 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933281031 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933279828 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometConstantColumnReader.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933278905 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometConstantColumnReader.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933275658 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933274637 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933272409 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/ParquetReaderType.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933272409 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/ParquetReaderType.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933270313 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/ParquetReaderType.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933266867 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/ParquetReaderType.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933264512 ## spark/v3.4/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java: ## @@ -44,7 +45,7 @@ public void dropTable() { // Run through our Doc's

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933263274 ## .baseline/checkstyle/checkstyle-suppressions.xml: ## @@ -48,4 +48,7 @@ + Review Comment: I wish Comet would offer an API that wraps around shad

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933257006 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWriterV2.java: ## @@ -214,7 +215,7 @@ public void testWriteWithCaseSensitiveOption()

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933257006 ## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWriterV2.java: ## @@ -214,7 +215,7 @@ public void testWriteWithCaseSensitiveOption()

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933255066 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java: ## @@ -27,6 +27,10 @@ private SparkSQLProperties() {} // Controls whether vec

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933253432 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatch.java: ## @@ -154,6 +172,17 @@ private boolean supportsParquetBatchReads(Types.NestedFi

Re: [PR] Kafka Connect: Add kerberos authentication option [iceberg]

Dawnpool commented on PR #12119: URL: https://github.com/apache/iceberg/pull/12119#issuecomment-2620702948 Hi @jbonofre Absolutely! I'll try to add test code once the maintainers agree on this feature. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] feat(catalog): Initial implementation of sql catalog [iceberg-go]

kevinjqliu commented on code in PR #246: URL: https://github.com/apache/iceberg-go/pull/246#discussion_r1933168044 ## catalog/sql/sql.go: ## @@ -0,0 +1,721 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTI

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933166909 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java: ## @@ -27,6 +27,10 @@ private SparkSQLProperties() {} // Controls whether vecto

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933168544 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933167720 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933166269 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] support create table like in flink catalog and watermark in windows [iceberg]

swapna267 commented on PR #12116: URL: https://github.com/apache/iceberg/pull/12116#issuecomment-2620523105 **Background:** 1. Creation of dynamic Iceberg table in Flink Catalog using the underlying physical Iceberg table using LIKE clause. Currently (without the changes in PR), c

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933114601 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometVector.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Spark: Action to remove missing files [iceberg]

wypoon commented on code in PR #12106: URL: https://github.com/apache/iceberg/pull/12106#discussion_r1932747579 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RemoveMissingFilesSparkAction.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933115883 ## .baseline/checkstyle/checkstyle-suppressions.xml: ## @@ -48,4 +48,7 @@ + Review Comment: Comet shades arrow, protobuf and guava. ``` impor

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933109421 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/ParquetReaderType.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933113150 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933112941 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933112611 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933111963 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnarBatchReader.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933109243 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java: ## @@ -359,4 +359,12 @@ public boolean reportColumnStats() { .defaultValue(S

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933108566 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java: ## @@ -27,6 +27,10 @@ private SparkSQLProperties() {} // Controls whether vec

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933105710 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/ParquetReaderType.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933104797 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/ParquetReaderType.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Iceberg/Comet integration POC [iceberg]

huaxingao commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933104427 ## spark/v3.4/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java: ## @@ -44,7 +45,7 @@ public void dropTable() { // Run through our Doc's G

Re: [I] Downloads link to Flink 1.20 runtime for Iceberg 1.6.1 leads to 404 [iceberg]

Ge commented on issue #11237: URL: https://github.com/apache/iceberg/issues/11237#issuecomment-2620455822 Flink 1.20 runtime has been released and that link works now. I am closing this issue. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [I] Downloads link to Flink 1.20 runtime for Iceberg 1.6.1 leads to 404 [iceberg]

Ge closed issue #11237: Downloads link to Flink 1.20 runtime for Iceberg 1.6.1 leads to 404 URL: https://github.com/apache/iceberg/issues/11237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933101318 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933075636 ## spark/v3.4/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java: ## @@ -44,7 +45,7 @@ public void dropTable() { // Run through our Doc's

Re: [PR] Iceberg/Comet integration POC [iceberg]

aokolnychyi commented on code in PR #9841: URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933075325 ## .baseline/checkstyle/checkstyle-suppressions.xml: ## @@ -48,4 +48,7 @@ + Review Comment: I see there are imports of shaded classes in `CometCol

Re: [I] On iceberg11 getting s3 connection reset error [iceberg]

anirbanroyeasygo commented on issue #4457: URL: https://github.com/apache/iceberg/issues/4457#issuecomment-2620360127 I am getting a similar issue consuming from kinesis and merging into an iceberg table. My spark structured streaming code works when its inserting the data into a new file b

Re: [PR] feat(catalog): Initial implementation of sql catalog [iceberg-go]

curtisr7 commented on code in PR #246: URL: https://github.com/apache/iceberg-go/pull/246#discussion_r1933057266 ## catalog/sql/sql.go: ## @@ -0,0 +1,712 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE

Re: [PR] Propagate ctx from catalog interface through call stack [iceberg-go]

curtisr7 commented on code in PR #276: URL: https://github.com/apache/iceberg-go/pull/276#discussion_r1933056167 ## catalog/glue/glue.go: ## @@ -69,7 +69,7 @@ var ( func init() { catalog.Register("glue", catalog.RegistrarFunc(func(_ string, props iceberg.Properties)

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

amogh-jahagirdar commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1933045814 ## gcp-bundle/NOTICE: ## @@ -29,72 +28,106 @@ from the source code management (SCM) system project uses.

Re: [I] Configure timestamp downcast programmatically [iceberg-python]

github-actions[bot] commented on issue #960: URL: https://github.com/apache/iceberg-python/issues/960#issuecomment-2620316367 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity oc

Re: [I] support bloom-filter writing [iceberg-python]

github-actions[bot] commented on issue #850: URL: https://github.com/apache/iceberg-python/issues/850#issuecomment-2620316392 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity oc

Re: [I] 0x1F as nested namespace separator for REST URL paths conflicts with Servlet spec [iceberg]

github-actions[bot] commented on issue #10338: URL: https://github.com/apache/iceberg/issues/10338#issuecomment-2620313724 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [I] Kafka Connect: Include design docs [iceberg]

github-actions[bot] commented on issue #10841: URL: https://github.com/apache/iceberg/issues/10841#issuecomment-2620313829 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occur

Re: [PR] OpenAPI: add initial/write defaults to schema [iceberg]

danielcweeks commented on code in PR #12094: URL: https://github.com/apache/iceberg/pull/12094#discussion_r1933030915 ## core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponse.java: ## @@ -147,6 +147,23 @@ public void testRoundTripSerdeWithV2TableMetadata() t

Re: [PR] OpenAPI: add initial/write defaults to schema [iceberg]

danielcweeks commented on code in PR #12094: URL: https://github.com/apache/iceberg/pull/12094#discussion_r1933029579 ## open-api/rest-catalog-open-api.yaml: ## @@ -2052,6 +2052,10 @@ components: type: boolean doc: type: string +initial-def

Re: [PR] Flink: Add null check to writers to prevent resurrecting null values [iceberg]

stevenzwu commented on code in PR #12049: URL: https://github.com/apache/iceberg/pull/12049#discussion_r1932969801 ## data/src/test/java/org/apache/iceberg/data/DataTest.java: ## @@ -486,4 +490,20 @@ public void testPrimitiveTypeDefaultValues(Type.PrimitiveType type, Object def

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

amogh-jahagirdar commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932981950 ## gcp-bundle/NOTICE: ## @@ -1,5 +1,4 @@ - -Apache Iceberg +Apache Iceberg (GCP Bundle) Review Comment: I'd say no empty first line (and it should be con

Re: [PR] feat(catalog): Initial implementation of sql catalog [iceberg-go]

zeroshade commented on code in PR #246: URL: https://github.com/apache/iceberg-go/pull/246#discussion_r1932851089 ## catalog/sql/sql.go: ## @@ -0,0 +1,712 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTIC

Re: [PR] Propagate ctx from catalog interface through call stack [iceberg-go]

zeroshade commented on code in PR #276: URL: https://github.com/apache/iceberg-go/pull/276#discussion_r1932887872 ## catalog/rest/rest.go: ## @@ -82,7 +82,7 @@ var ( func init() { reg := catalog.RegistrarFunc(func(name string, p iceberg.Properties) (catalog.Catalog,

Re: [I] Add support for encrypted/protected data type in iceberg table [iceberg-python]

yigal-rozenberg commented on issue #1582: URL: https://github.com/apache/iceberg-python/issues/1582#issuecomment-2620105176 Before posting this as a proper improvement request, I would like to come up with a POC that demonstrate the desired functionality/ The thread you provided talks abou

Re: [PR] Propagate ctx from catalog interface through call stack [iceberg-go]

zeroshade commented on code in PR #276: URL: https://github.com/apache/iceberg-go/pull/276#discussion_r1932886875 ## catalog/glue/glue.go: ## @@ -69,7 +69,7 @@ var ( func init() { catalog.Register("glue", catalog.RegistrarFunc(func(_ string, props iceberg.Properties)

Re: [I] How to query NON Iceberg format tables (created in aws Athena) from spark? [iceberg]

boaz-g commented on issue #10524: URL: https://github.com/apache/iceberg/issues/10524#issuecomment-2620056733 Hello Salah, i am facing the same config challenge . Can you please post the final conf for the spark session - that supports iceberg and non-iceberg tables in my glue catalog?

Re: [I] Issue in Reading Iceberg tables in Nessie + Minio using Pyiceberg [iceberg-python]

kevinjqliu commented on issue #1560: URL: https://github.com/apache/iceberg-python/issues/1560#issuecomment-2620089427 @HungYangChang i would recommend looking at nessie documentation on how to connect to an iceberg rest catalog. Pyiceberg accepts the standard iceberg rest catalog configur

Re: [I] How to read/write Iceberg table from/to ADLS gen 2 container with PyIceberg [iceberg-python]

kevinjqliu commented on issue #1588: URL: https://github.com/apache/iceberg-python/issues/1588#issuecomment-2620086360 > I still cannot figure out how to read/write the Iceberg table from/to ADLS gen2 with PyIceberg in pyiceberg, you would need to configure both the [catalog](https

Re: [PR] feat(catalog): Initial implementation of sql catalog [iceberg-go]

zeroshade commented on PR #246: URL: https://github.com/apache/iceberg-go/pull/246#issuecomment-2620069582 updated from @curtisr7's suggestions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[I] Using tables created in Hive Catalog in Hadoop catalog [iceberg]

guykhazma opened a new issue, #12125: URL: https://github.com/apache/iceberg/issues/12125 ### Feature Request / Improvement We have a scenario where we have tables created with Hive Catalog and then in a separate application we would like to be able to define a Hadoop Catalog that sh

Re: [PR] feat(catalog): Initial implementation of sql catalog [iceberg-go]

zeroshade commented on code in PR #246: URL: https://github.com/apache/iceberg-go/pull/246#discussion_r1932847208 ## catalog/sql/sql.go: ## @@ -0,0 +1,712 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTIC

Re: [PR] feat(catalog): Initial implementation of sql catalog [iceberg-go]

zeroshade commented on code in PR #246: URL: https://github.com/apache/iceberg-go/pull/246#discussion_r1932844716 ## catalog/sql/sql.go: ## @@ -0,0 +1,712 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTIC

Re: [PR] Add CheckTableExists method for rest.go [iceberg-go]

zeroshade commented on code in PR #277: URL: https://github.com/apache/iceberg-go/pull/277#discussion_r1932843254 ## catalog/rest/rest_test.go: ## @@ -844,6 +844,53 @@ func (r *RestCatalogSuite) TestCreateTable409() { r.ErrorIs(err, catalog.ErrTableAlreadyExists) } +f

Re: [PR] Add CheckTableExists method for rest.go [iceberg-go]

zeroshade commented on code in PR #277: URL: https://github.com/apache/iceberg-go/pull/277#discussion_r1932842938 ## catalog/rest/rest_test.go: ## @@ -844,6 +844,53 @@ func (r *RestCatalogSuite) TestCreateTable409() { r.ErrorIs(err, catalog.ErrTableAlreadyExists) } +f

Re: [PR] Add CheckTableExists method for rest.go [iceberg-go]

zeroshade commented on code in PR #277: URL: https://github.com/apache/iceberg-go/pull/277#discussion_r1932842308 ## README.md: ## @@ -70,6 +70,7 @@ $ cd iceberg-go/cmd/iceberg && go build . | Rename Table | X | | | X | | Drop Table

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932838112 ## gcp-bundle/NOTICE: ## @@ -1,5 +1,4 @@ - -Apache Iceberg +Apache Iceberg (GCP Bundle) Review Comment: do we want to keep this empty first line ? -- This is

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932837482 ## azure-bundle/NOTICE: ## @@ -1,5 +1,4 @@ - -Apache Iceberg +Apache Iceberg (Azure bundle) Review Comment: do we want to keep the empty line ? I mean I don't se

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

Fokko commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932831211 ## azure-bundle/NOTICE: ## @@ -1,5 +1,4 @@ - -Apache Iceberg +Apache Iceberg (Azure bundle) Review Comment: There's a new line on the AWS bundle: https://git

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932557613 ## azure-bundle/NOTICE: ## @@ -28,3 +27,272 @@ To find the details that apply to this artifact see the accompanying LICENSE fil A list of contributors may be found

[PR] Add CheckTableExists method for rest.go [iceberg-go]

dttung2905 opened a new pull request, #277: URL: https://github.com/apache/iceberg-go/pull/277 Similar to the `CheckNamespaceExists` method, I add a new method called `CheckTableExists` and add some unit tests -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add relevant NOTICE portions from ALv2 bundled dependencies [iceberg]

jbonofre commented on code in PR #12095: URL: https://github.com/apache/iceberg/pull/12095#discussion_r1932559418 ## azure-bundle/NOTICE: ## @@ -28,3 +27,272 @@ To find the details that apply to this artifact see the accompanying LICENSE fil A list of contributors may be found

Re: [PR] Spark: Support singular form of years, months, days, and hours functions [iceberg]

wypoon commented on PR #12117: URL: https://github.com/apache/iceberg/pull/12117#issuecomment-2619901256 @Fokko @nastra would you mind reviewing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Spark: Action to remove missing files [iceberg]

wypoon commented on code in PR #12106: URL: https://github.com/apache/iceberg/pull/12106#discussion_r1932747579 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RemoveMissingFilesSparkAction.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Fou

  1   2   3   >