aokolnychyi commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933253432
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatch.java:
##########
@@ -154,6 +172,17 @@ private boolean
supportsParquetBatchReads(Types.NestedField field) {
return field.type().isPrimitiveType() ||
MetadataColumns.isMetadataColumn(field.fieldId());
}
+ private boolean useCometBatchReads() {
+ return readConf.parquetVectorizationEnabled()
+ && readConf.parquetReaderType() == ParquetReaderType.COMET
+ &&
expectedSchema.columns().stream().allMatch(this::supportsCometBatchReads)
+ && taskGroups.stream().allMatch(this::supportsParquetBatchReads);
Review Comment:
It is safe to reuse `supportsParquetBatchReads` because the logic is the
same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
