ajantha-bhat commented on code in PR #12102:
URL: https://github.com/apache/iceberg/pull/12102#discussion_r1933383048
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -214,10 +214,8 @@ public Optional<ParquetValueReader<?>> visit(
@Override
public Optional<ParquetValueReader<?>> visit(IntLogicalTypeAnnotation
intLogicalType) {
if (intLogicalType.getBitWidth() == 64) {
- if (intLogicalType.isSigned()) {
- // this will throw an UnsupportedOperationException
- return Optional.empty();
- }
+ Preconditions.checkArgument(
Review Comment:
We wanted to throw the exception when it is signed right?
Now it throws when it is unsigned. check should be inverted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
