aokolnychyi commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1933263274
##########
.baseline/checkstyle/checkstyle-suppressions.xml:
##########
@@ -48,4 +48,7 @@
<!-- Referencing guava classes should be allowed in classes within
bundled-guava module -->
<suppress files="org.apache.iceberg.GuavaClasses"
id="BanUnrelocatedGuavaClasses"/>
+
Review Comment:
I wish Comet would offer an API that wraps around shaded dependencies, so
that we don’t have to reference shaded classes directly. It is a bit odd. I
always considered shading an internal detail rather than something that would
leak into a public API.
Thoughts, @RussellSpitzer @Fokko @nastra @amogh-jahagirdar @danielcweeks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
