Re: [PR] Use ArrowScan.to_table to replace project_table [iceberg-python]

2024-09-19 Thread via GitHub
JE-Chen commented on PR #1180: URL: https://github.com/apache/iceberg-python/pull/1180#issuecomment-2362965089 My Windows environment has the same pull issue. ![{ADD7151F-C1E1-48BE-96AB-F1575E271E57}](https://github.com/user-attachments/assets/0a5f6d74-c2ba-4694-be69-bd31f9adeb4d)

Re: [PR] Use ArrowScan.to_table to replace project_table [iceberg-python]

2024-09-19 Thread via GitHub
kevinjqliu commented on PR #1180: URL: https://github.com/apache/iceberg-python/pull/1180#issuecomment-2362951863 seems like its an issue with your docker installation. https://github.com/apache/iceberg-python/blob/41a3c8ea4e9c3592331755970bfc38f52eaf3fd8/dev/docker-compose-integrati

Re: [PR] Use ArrowScan.to_table to replace project_table [iceberg-python]

2024-09-19 Thread via GitHub
JE-Chen commented on PR #1180: URL: https://github.com/apache/iceberg-python/pull/1180#issuecomment-2362928724 I’m trying to remove all docker images and re-run make-integration, and I noticed this. So, I think the test failed because: Can’t pull the python-integration image (access de

Re: [I] Create table format version constants [iceberg-python]

2024-09-19 Thread via GitHub
kevinjqliu commented on issue #851: URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2362876509 Yep I think that should be fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Core: Allow manifest file cache to be configurable [iceberg]

2024-09-19 Thread via GitHub
yingsu00 commented on PR #10118: URL: https://github.com/apache/iceberg/pull/10118#issuecomment-2362864740 Gentle ping @singhpk234 @amogh-jahagirdar thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] Create table format version constants [iceberg-python]

2024-09-19 Thread via GitHub
tanmayrauth commented on issue #851: URL: https://github.com/apache/iceberg-python/issues/851#issuecomment-2362853568 So, I shall convert it to an Enum, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-19 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1767994001 ## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ## @@ -153,6 +154,12 @@ void caseSensitive(boolean newCaseSensitive) { void delete(F

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-19 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1767994001 ## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ## @@ -153,6 +154,12 @@ void caseSensitive(boolean newCaseSensitive) { void delete(F

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-19 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1767994001 ## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ## @@ -153,6 +154,12 @@ void caseSensitive(boolean newCaseSensitive) { void delete(F

Re: [I] Spark configuration for amazon access key and secret key with glue catalog for apache Iceberg is not honoring [iceberg]

2024-09-19 Thread via GitHub
AwasthiSomesh commented on issue #10078: URL: https://github.com/apache/iceberg/issues/10078#issuecomment-2362808067 based on above details it working fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Spark configuration for amazon access key and secret key with glue catalog for apache Iceberg is not honoring [iceberg]

2024-09-19 Thread via GitHub
AwasthiSomesh closed issue #10078: Spark configuration for amazon access key and secret key with glue catalog for apache Iceberg is not honoring URL: https://github.com/apache/iceberg/issues/10078 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Iceberg Read is not working on Iceberg Hive table [iceberg]

2024-09-19 Thread via GitHub
AwasthiSomesh commented on issue #11168: URL: https://github.com/apache/iceberg/issues/11168#issuecomment-2362805851 @manuzhang its hive 4.0.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Core: Avro writers use BlockingBinaryEncoder to enable array/map size calculations. [iceberg]

2024-09-19 Thread via GitHub
rustyconover commented on PR #8625: URL: https://github.com/apache/iceberg/pull/8625#issuecomment-2362721315 @Fokko should we keep this alive? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] feat: expose arrow type <-> iceberg type [iceberg-rust]

2024-09-19 Thread via GitHub
Xuanwo commented on PR #637: URL: https://github.com/apache/iceberg-rust/pull/637#issuecomment-2362719938 > Do you think it would be enough to add one or two simple api call examples I believe that's enough. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat: expose arrow type <-> iceberg type [iceberg-rust]

2024-09-19 Thread via GitHub
xxchan commented on PR #637: URL: https://github.com/apache/iceberg-rust/pull/637#issuecomment-2362703377 Ok. Do you think it would be enough to add one or two simple api call examples, or it should cover all cases like schema test? On Fri, 20 Sep 2024 at 11:43, Xuanwo ***@***.***>

Re: [PR] feat: expose arrow type <-> iceberg type [iceberg-rust]

2024-09-19 Thread via GitHub
Xuanwo commented on PR #637: URL: https://github.com/apache/iceberg-rust/pull/637#issuecomment-2362697248 > I think the tests are already covered by schema conversion tests, as type conversion is just a sub-feature of schema conversion. Hi, I understand that the logic might be covered

Re: [PR] feat: expose arrow type <-> iceberg type [iceberg-rust]

2024-09-19 Thread via GitHub
xxchan commented on PR #637: URL: https://github.com/apache/iceberg-rust/pull/637#issuecomment-2362690730 I think the tests are already covered by schema conversion tests, as type conversion is just a sub-feature of schema conversion. -- This is an automated message from the Apache Git Se

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-19 Thread via GitHub
amogh-jahagirdar commented on PR #11131: URL: https://github.com/apache/iceberg/pull/11131#issuecomment-2362678032 Seems like after my latest updates some cherry pick test cases are failing. Taking a look: ``` TestSnapshotManager > testCherryPickDynamicOverwrite() > formatVersion =

Re: [PR] Core: Optimize MergingSnapshotProducer to use referenced manifests to determine if manifest needs to be rewritten [iceberg]

2024-09-19 Thread via GitHub
amogh-jahagirdar commented on code in PR #11131: URL: https://github.com/apache/iceberg/pull/11131#discussion_r1767892495 ## core/src/test/java/org/apache/iceberg/TestRowDelta.java: ## @@ -1456,6 +1457,58 @@ public void testRewrittenDeleteFiles() { statuses(Status.DELET

Re: [PR] API: Add RemoveUnusedSpecs in Table [iceberg]

2024-09-19 Thread via GitHub
advancedxy commented on PR #10755: URL: https://github.com/apache/iceberg/pull/10755#issuecomment-2362587553 > yes I think we should send the new update type as part of this PR.that would require some parser changes as well for the update type. Let me know if any help is needed, I can try t

Re: [I] Iceberg Read is not working on Iceberg Hive table [iceberg]

2024-09-19 Thread via GitHub
manuzhang commented on issue #11168: URL: https://github.com/apache/iceberg/issues/11168#issuecomment-2362588708 what's your hive version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] Supplement test case for `RollbackToTimestampProcedure` [iceberg]

2024-09-19 Thread via GitHub
hantangwangd opened a new pull request, #11171: URL: https://github.com/apache/iceberg/pull/11171 The current test cases for `RollbackToTimestampProcedure` do not cover the scenario where the timestamp we specified is earlier than or equal to the timestamp of the oldest snapshot. In suc

Re: [PR] API: Add RemoveUnusedSpecs in Table [iceberg]

2024-09-19 Thread via GitHub
amogh-jahagirdar commented on PR #10755: URL: https://github.com/apache/iceberg/pull/10755#issuecomment-2362521114 Sorry for missing following up on this @advancedxy yes I think we should send the new update type as part of this PR.that would require some parser changes as well for the upda

Re: [PR] [feature] reimplement Snapshot manifest cache [iceberg-python]

2024-09-19 Thread via GitHub
sungwy commented on code in PR #1185: URL: https://github.com/apache/iceberg-python/pull/1185#discussion_r1767792939 ## pyiceberg/table/snapshots.py: ## @@ -249,6 +241,9 @@ class Snapshot(IcebergBaseModel): summary: Optional[Summary] = Field(default=None) schema_id: Op

Re: [PR] Core: Widen exceptions ignored while deleting files in RollingFileWriter [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8597: URL: https://github.com/apache/iceberg/pull/8597#issuecomment-2362460683 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] Cannot specify custom delete handler when using a DeleteFiles in a Transaction [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8642: URL: https://github.com/apache/iceberg/issues/8642#issuecomment-2362461601 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Write format arrow [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8580: URL: https://github.com/apache/iceberg/issues/8580#issuecomment-2362460226 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Dropping a previous Iceberg sort order field causes org.apache.iceberg.exceptions.ValidationException [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8614: URL: https://github.com/apache/iceberg/issues/8614#issuecomment-2362461224 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Core: Use avro compression properties from table properties when writing manifests and manifest lists (API change) [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8617: URL: https://github.com/apache/iceberg/pull/8617#issuecomment-2362461302 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] Debug sporadic structured streaming failures [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8603: URL: https://github.com/apache/iceberg/issues/8603#issuecomment-2362460979 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Large Iceberg Parquet file writes are (sometimes?) truncated [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8620: URL: https://github.com/apache/iceberg/issues/8620#issuecomment-2362461364 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Hive: Use timezone of the object inspector while constructing primitive Java objects for timestamp with local time zone [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] closed pull request #8113: Hive: Use timezone of the object inspector while constructing primitive Java objects for timestamp with local time zone URL: https://github.com/apache/iceberg/pull/8113 -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Spec: Clarify the semantics of `identifier-field-ids` [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8623: URL: https://github.com/apache/iceberg/pull/8623#issuecomment-2362461426 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Add Support for Dynamic Overwrite [iceberg-python]

2024-09-19 Thread via GitHub
sungwy commented on PR #931: URL: https://github.com/apache/iceberg-python/pull/931#issuecomment-2362472247 Thank you for making this contribution @jqin61 ! I'll leave this PR open for another review -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-19 Thread via GitHub
sungwy merged PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@icebe

Re: [PR] Add metadata tables for `data_files` and `delete_files` [iceberg-python]

2024-09-19 Thread via GitHub
sungwy commented on PR #1066: URL: https://github.com/apache/iceberg-python/pull/1066#issuecomment-2362470444 Thanks for making this contribution @soumya-ghosh ! And thank you @kevinjqliu and @ndrluis for the detailed reviews! -- This is an automated message from the Apache Git Service. T

Re: [I] Support Zorder for data writes (not just rewrites) [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8674: URL: https://github.com/apache/iceberg/issues/8674#issuecomment-2362461906 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] ALTER TABLE ... DROP COLUMN allows dropping the last column of a table [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8522: URL: https://github.com/apache/iceberg/issues/8522#issuecomment-2362459924 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Docs: Improve branch/tagging branch fast-forward (branch always on HEAD) semantics [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8638: URL: https://github.com/apache/iceberg/issues/8638#issuecomment-2362461560 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Core: Avro writers use BlockingBinaryEncoder to enable array/map size calculations. [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8625: URL: https://github.com/apache/iceberg/pull/8625#issuecomment-2362461471 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] Rest catalog server doesn't return table configuration as expected. [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8526: URL: https://github.com/apache/iceberg/issues/8526#issuecomment-2362459981 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Prevent dropping last column. [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8523: URL: https://github.com/apache/iceberg/pull/8523#issuecomment-2362459955 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] pyiceberg 0.5.0 cli __init__() takes at least 1 positional argument (0 given) [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8606: URL: https://github.com/apache/iceberg/issues/8606#issuecomment-2362461059 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] To fix the table configuration documentation for write.distrubition-mode [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8517: URL: https://github.com/apache/iceberg/pull/8517#issuecomment-2362459889 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Make FanoutWriter a package public class [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8581: URL: https://github.com/apache/iceberg/pull/8581#issuecomment-2362460429 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] Discrepancy between table configuration default value and Spark documentation [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8516: URL: https://github.com/apache/iceberg/issues/8516#issuecomment-2362459862 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] How does iceberg solve the problem of small files? Is there any good solution? [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8663: URL: https://github.com/apache/iceberg/issues/8663#issuecomment-2362461799 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Core: Mark `503: added_snapshot_id` as required [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8673: URL: https://github.com/apache/iceberg/pull/8673#issuecomment-2362461861 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] Snapshot Expiration Behavior Inconsistency with TIMESTAMP AS OF and VERSION AS OF [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8565: URL: https://github.com/apache/iceberg/issues/8565#issuecomment-2362460132 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] mr: junit5 upgrade [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8100: URL: https://github.com/apache/iceberg/pull/8100#issuecomment-2362459586 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [I] Could there be duplicate values in the result returned by the findOrphanFiles method? [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8670: URL: https://github.com/apache/iceberg/issues/8670#issuecomment-2362461822 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Flink: new sink base on the unified sink API - WIP [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8653: URL: https://github.com/apache/iceberg/pull/8653#issuecomment-2362461718 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] Document Azure and GCP integration [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8662: URL: https://github.com/apache/iceberg/issues/8662#issuecomment-2362461758 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Core: Refactor RestCatalogAdapter to use existing HttpMethod enum [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8543: URL: https://github.com/apache/iceberg/pull/8543#issuecomment-2362460050 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [PR] Core: Add AsyncFileIO [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8644: URL: https://github.com/apache/iceberg/pull/8644#issuecomment-2362461675 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] spark read error with Failed to open file [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8635: URL: https://github.com/apache/iceberg/issues/8635#issuecomment-2362461520 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Ambiguiety around `list`, `map` and `struct` null counts [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8598: URL: https://github.com/apache/iceberg/issues/8598#issuecomment-2362460845 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Spec: Add section on `null_value_counts` [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8611: URL: https://github.com/apache/iceberg/pull/8611#issuecomment-2362461148 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] ConnectionUrl property for CatalogProperties [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8557: URL: https://github.com/apache/iceberg/issues/8557#issuecomment-2362460089 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] AWS: Throw relevant exception at namespaceExists check usage in Glue Catalog [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8533: URL: https://github.com/apache/iceberg/pull/8533#issuecomment-2362460014 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

Re: [I] CASCADE WITH Drop Namespace Gives exception [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8529: URL: https://github.com/apache/iceberg/issues/8529#issuecomment-2362460001 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Iceberg table support specified column comments by flinksql create [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8511: URL: https://github.com/apache/iceberg/issues/8511#issuecomment-2362459845 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Core: Support delete rows changelog scan task [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] closed pull request #8083: Core: Support delete rows changelog scan task URL: https://github.com/apache/iceberg/pull/8083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] Iceberg does not trigger actually rewrite_data_files in certain situations [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8510: URL: https://github.com/apache/iceberg/issues/8510#issuecomment-2362459825 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] spark sql delete or merge can support run in batch? [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on issue #8509: URL: https://github.com/apache/iceberg/issues/8509#issuecomment-2362459804 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Hive: Use timezone of the object inspector while constructing primitive Java objects for timestamp with local time zone [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8113: URL: https://github.com/apache/iceberg/pull/8113#issuecomment-2362459676 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Core, AWS: Support Lambda-based HTTP client for REST catalog [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] closed pull request #8091: Core, AWS: Support Lambda-based HTTP client for REST catalog URL: https://github.com/apache/iceberg/pull/8091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Core: Support delete rows changelog scan task [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8083: URL: https://github.com/apache/iceberg/pull/8083#issuecomment-2362459484 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Api:Fix add the same listener to the same listeners queue multiple times [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8108: URL: https://github.com/apache/iceberg/pull/8108#issuecomment-2362459617 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] mr: junit5 upgrade [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] closed pull request #8100: mr: junit5 upgrade URL: https://github.com/apache/iceberg/pull/8100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Api:Fix add the same listener to the same listeners queue multiple times [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] closed pull request #8108: Api:Fix add the same listener to the same listeners queue multiple times URL: https://github.com/apache/iceberg/pull/8108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Core, AWS: Support Lambda-based HTTP client for REST catalog [iceberg]

2024-09-19 Thread via GitHub
github-actions[bot] commented on PR #8091: URL: https://github.com/apache/iceberg/pull/8091#issuecomment-2362459535 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Bump mypy-boto3-glue from 1.35.3 to 1.35.18 [iceberg-python]

2024-09-19 Thread via GitHub
dependabot[bot] closed pull request #1171: Bump mypy-boto3-glue from 1.35.3 to 1.35.18 URL: https://github.com/apache/iceberg-python/pull/1171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Bump mypy-boto3-glue from 1.35.3 to 1.35.18 [iceberg-python]

2024-09-19 Thread via GitHub
dependabot[bot] commented on PR #1171: URL: https://github.com/apache/iceberg-python/pull/1171#issuecomment-2362345511 Superseded by #1186. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] Bump mypy-boto3-glue from 1.35.3 to 1.35.23 [iceberg-python]

2024-09-19 Thread via GitHub
dependabot[bot] opened a new pull request, #1186: URL: https://github.com/apache/iceberg-python/pull/1186 Bumps [mypy-boto3-glue](https://github.com/youtype/mypy_boto3_builder) from 1.35.3 to 1.35.23. Commits See full diff in https://github.com/youtype/mypy_boto3_builder/commit

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767640808 ## format/spec.md: ## @@ -1000,59 +1010,66 @@ Values should be stored in Parquet using the types and logical type annotations Lists must use the [3-level

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767646758 ## format/spec.md: ## @@ -454,28 +465,28 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo `data_file` is a struct with t

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767646192 ## format/spec.md: ## @@ -200,12 +200,15 @@ Supported primitive types are defined in the table below. Primitive types added | | **`uuid`**

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767636977 ## format/spec.md: ## @@ -968,13 +978,13 @@ Maps with non-string keys must use an array representation with the `map` logica |**`struct`**|`record`|| |**`li

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767644014 ## format/spec.md: ## @@ -1265,27 +1287,28 @@ Example This serialization scheme is for storing single values as individual binary values in the lower and u

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767643715 ## format/spec.md: ## @@ -1312,7 +1335,7 @@ This serialization scheme is for storing single values as individual binary valu | **`struct`** | **`JSON o

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767641570 ## format/spec.md: ## @@ -1101,7 +1120,8 @@ Hash results are not dependent on decimal scale, which is part of the type, not 3. Nanosecond timestamps must be

Re: [PR] Support changelog scan for table with delete files [iceberg]

2024-09-19 Thread via GitHub
wypoon commented on code in PR #10935: URL: https://github.com/apache/iceberg/pull/10935#discussion_r1767624705 ## core/src/test/java/org/apache/iceberg/TestBaseIncrementalChangelogScan.java: ## @@ -132,6 +131,175 @@ public void testFileDeletes() { assertThat(t1.existingDel

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767640504 ## format/spec.md: ## @@ -1000,59 +1010,66 @@ Values should be stored in Parquet using the types and logical type annotations Lists must use the [3-level

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767638643 ## format/spec.md: ## @@ -985,59 +997,66 @@ Values should be stored in Parquet using the types and logical type annotations Lists must use the [3-level re

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767636977 ## format/spec.md: ## @@ -968,13 +978,13 @@ Maps with non-string keys must use an array representation with the `map` logica |**`struct`**|`record`|| |**`li

Re: [PR] Support changelog scan for table with delete files [iceberg]

2024-09-19 Thread via GitHub
wypoon commented on code in PR #10935: URL: https://github.com/apache/iceberg/pull/10935#discussion_r1767624705 ## core/src/test/java/org/apache/iceberg/TestBaseIncrementalChangelogScan.java: ## @@ -132,6 +131,175 @@ public void testFileDeletes() { assertThat(t1.existingDel

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767636137 ## format/spec.md: ## @@ -454,28 +466,28 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo `data_file` is a struct with t

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767636137 ## format/spec.md: ## @@ -454,28 +466,28 @@ The schema of a manifest file is a struct called `manifest_entry` with the follo `data_file` is a struct with t

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767634355 ## format/spec.md: ## @@ -383,6 +388,13 @@ Notes: 3. Strings are truncated to a valid UTF-8 string with no more than `L` code points. 4. In contrast to stri

Re: [PR] Support changelog scan for table with delete files [iceberg]

2024-09-19 Thread via GitHub
wypoon commented on code in PR #10935: URL: https://github.com/apache/iceberg/pull/10935#discussion_r1767624705 ## core/src/test/java/org/apache/iceberg/TestBaseIncrementalChangelogScan.java: ## @@ -132,6 +131,175 @@ public void testFileDeletes() { assertThat(t1.existingDel

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767627698 ## format/spec.md: ## @@ -200,12 +200,16 @@ Supported primitive types are defined in the table below. Primitive types added | | **`uuid`**

Re: [PR] Spec: Support geo type [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10981: URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767627698 ## format/spec.md: ## @@ -200,12 +200,16 @@ Supported primitive types are defined in the table below. Primitive types added | | **`uuid`**

Re: [PR] Support changelog scan for table with delete files [iceberg]

2024-09-19 Thread via GitHub
wypoon commented on code in PR #10935: URL: https://github.com/apache/iceberg/pull/10935#discussion_r1767624705 ## core/src/test/java/org/apache/iceberg/TestBaseIncrementalChangelogScan.java: ## @@ -132,6 +131,175 @@ public void testFileDeletes() { assertThat(t1.existingDel

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767620992 ## format/spec.md: ## @@ -1267,6 +1304,7 @@ This serialization scheme is for storing single values as individual binary valu | **`fixed(L)`** |

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767620992 ## format/spec.md: ## @@ -1267,6 +1304,7 @@ This serialization scheme is for storing single values as individual binary valu | **`fixed(L)`** |

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767618482 ## format/spec.md: ## @@ -1003,6 +1032,7 @@ Lists must use the [3-level representation](https://github.com/apache/parquet-fo | **`uuid`** | `fixed_le

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767616876 ## format/spec.md: ## @@ -222,11 +228,31 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to t

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767613662 ## format/spec.md: ## @@ -222,11 +228,31 @@ Schemas may be evolved by type promotion or adding, deleting, renaming, or reord Evolution applies changes to t

Re: [PR] Spec: Add v3 types and type promotion [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #10955: URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767610889 ## format/spec.md: ## @@ -174,6 +174,7 @@ Supported primitive types are defined in the table below. Primitive types added | Added by version | Primitive ty

  1   2   >