RussellSpitzer commented on code in PR #10955:
URL: https://github.com/apache/iceberg/pull/10955#discussion_r1767620992


##########
format/spec.md:
##########
@@ -1267,6 +1304,7 @@ This serialization scheme is for storing single values as 
individual binary valu
 | **`fixed(L)`**               | Binary value                                  
                                                               |
 | **`binary`**                 | Binary value (without length)                 
                                                               |
 | **`decimal(P, S)`**          | Stores unscaled value as two’s-complement 
big-endian binary, using the minimum number of bytes for the value |
+| **`variant`**                | Variant metadata bytes concatenated with 
variant value bytes                                                 |

Review Comment:
   I think for non-shredded lower and upper bounds we should define this as 
not-supported. I think as we had some discussion before, this can be Variant 
metadata bytes + values for shredded/sub-columnerized fields but only for those 
extracted fields. We'll probably have to define elsewhere how to actually 
calculate upper and lower bounds etc ....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to