Xuanwo commented on PR #637: URL: https://github.com/apache/iceberg-rust/pull/637#issuecomment-2362697248
> I think the tests are already covered by schema conversion tests, as type conversion is just a sub-feature of schema conversion. Hi, I understand that the logic might be covered by other parts, but we are adding new public APIs. How about adding unit tests directly for these new APIs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org