xxchan commented on PR #637: URL: https://github.com/apache/iceberg-rust/pull/637#issuecomment-2362703377
Ok. Do you think it would be enough to add one or two simple api call examples, or it should cover all cases like schema test? On Fri, 20 Sep 2024 at 11:43, Xuanwo ***@***.***> wrote: > I think the tests are already covered by schema conversion tests, as type > conversion is just a sub-feature of schema conversion. > > Hi, I understand that the logic might be covered by other parts, but we > are adding new public APIs. How about adding unit tests directly for these > new APIs? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg-rust/pull/637#issuecomment-2362697248>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AJBQZNOZSERQDYB2HSRQEI3ZXOKU3AVCNFSM6AAAAABOQEROPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSGY4TOMRUHA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
