RussellSpitzer commented on code in PR #10981:
URL: https://github.com/apache/iceberg/pull/10981#discussion_r1767646192
##########
format/spec.md:
##########
@@ -200,12 +200,15 @@ Supported primitive types are defined in the table below.
Primitive types added
| | **`uuid`** | Universally unique identifiers
| Should use 16-byte fixed
|
| | **`fixed(L)`** | Fixed-length byte array of length L
|
|
| | **`binary`** | Arbitrary-length byte array
|
|
+| [v3](#version-3) | **`geometry(C, E)`** | An object of the simple feature
geometry model as defined by Appendix G; This may be any of the geometry
subclasses defined therein; crs C [4], edges E [5] | C and E are fixed, and if
unset will take default values. |
Review Comment:
I think maybe we should just link out for the requirements here since it's a
bit complicated. Remove "an object"
The description as well could be
Simple feature geometry [Appendix
G](https://github.com/apache/iceberg/pull/10981#appendix-g), Parameterized by
....
I also don't think we should allow it to be unset ... can we just require
that a subclass is always picked? We could recommend a set of defaults for
engines to set on field creation but I'm not sure we need to be that
opinionated here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
