Fokko commented on issue #462:
URL: https://github.com/apache/iceberg-python/issues/462#issuecomment-1978155414
#484 went in, closing this one 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Fokko closed issue #462: Make the OAuth2 request scope configurable
URL: https://github.com/apache/iceberg-python/issues/462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Fokko commented on PR #489:
URL: https://github.com/apache/iceberg-python/pull/489#issuecomment-1978153309
@jqin61 sorry for the confusion there. We do this for the Literal itself:
https://github.com/apache/iceberg-python/blob/9d01b02f14e761b36fe0b88a82274037f7ced5a7/pyiceberg/expressions/li
Fokko commented on code in PR #473:
URL: https://github.com/apache/iceberg-python/pull/473#discussion_r1512278316
##
pyiceberg/table/metadata.py:
##
@@ -263,6 +264,12 @@ def sort_order_by_id(self, sort_order_id: int) ->
Optional[SortOrder]:
"""Get the sort order by sor
stream2000 commented on PR #230:
URL: https://github.com/apache/iceberg-rust/pull/230#issuecomment-1978144885
> Ok, but I prefer put it in `.idea/.gitignore`.
Sure and done, thanks for your review~
--
This is an automated message from the Apache Git Service.
To respond to the messag
liurenjie1024 commented on issue #150:
URL: https://github.com/apache/iceberg-rust/issues/150#issuecomment-1978143748
> @liurenjie1024 could you assign this task to me please? :-)
Yes, sure. Thanks for contributing!
--
This is an automated message from the Apache Git Service.
To res
Fokko merged PR #487:
URL: https://github.com/apache/iceberg-python/pull/487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
arvindeybram commented on issue #8343:
URL: https://github.com/apache/iceberg/issues/8343#issuecomment-1978136859
I am facing the same issue in pyspark - when creating external tables in
hive using ICEBERG format.
```ParseException:
[PARSE_SYNTAX_ERROR] Syntax error at or near 'ICEBER
Fokko commented on PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#issuecomment-1978136175
@himadripal Can you fix the issue here? And update the doc in the same PR?
Apart from that, this looks good. Thanks for working on this 👍
--
This is an automated message from the Ap
Fokko commented on PR #484:
URL: https://github.com/apache/iceberg-python/pull/484#issuecomment-1978135226
Thanks for working on this @himadripal and for the review @flyrain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Fokko commented on PR #495:
URL: https://github.com/apache/iceberg-python/pull/495#issuecomment-1978134798
Thanks for working on this @himadripal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sdd commented on code in PR #229:
URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1512266440
##
crates/catalog/sql/src/catalog.rs:
##
@@ -0,0 +1,397 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. Se
Fokko merged PR #484:
URL: https://github.com/apache/iceberg-python/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
sdd commented on issue #150:
URL: https://github.com/apache/iceberg-rust/issues/150#issuecomment-1978133744
@liurenjie1024 could you assign this task to me please? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Fokko merged PR #495:
URL: https://github.com/apache/iceberg-python/pull/495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko merged PR #496:
URL: https://github.com/apache/iceberg-python/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Xuanwo commented on PR #230:
URL: https://github.com/apache/iceberg-rust/pull/230#issuecomment-1978122647
> I think excluding `.idea/vcs.xml` in this way should be enough.
Ok, but I prefer put it in `.idea/.gitignore`.
--
This is an automated message from the Apache Git Service.
To
sdd commented on code in PR #229:
URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1512249728
##
crates/catalog/sql/src/catalog.rs:
##
@@ -0,0 +1,397 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. Se
huyuanfeng2018 commented on PR #9606:
URL: https://github.com/apache/iceberg/pull/9606#issuecomment-1978115143
> Thanks @huyuanfeng2018 for the PR and @stevenzwu for the review!
>
> @huyuanfeng2018: Could you please backport the changes to Flink 1.17 and
1.16?
>
> Thanks, Peter
stream2000 commented on PR #230:
URL: https://github.com/apache/iceberg-rust/pull/230#issuecomment-1978109062
> https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
```shell
.idea/*
!.idea/vcs.xml
```
I think excluding `.idea/vcs.xml` in this way should
sdd commented on code in PR #229:
URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1512233865
##
crates/catalog/sql/Cargo.toml:
##
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the N
rahil-c opened a new pull request, #9866:
URL: https://github.com/apache/iceberg/pull/9866
Minor revision for comments from @rdblue on the following pr:
https://github.com/apache/iceberg/pull/9660
cc @jackye1995
--
This is an automated message from the Apache Git Service.
To respo
sdd commented on PR #228:
URL: https://github.com/apache/iceberg-rust/pull/228#issuecomment-1978098358
@liurenjie1024: this is ready for review 👍🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stream2000 commented on PR #230:
URL: https://github.com/apache/iceberg-rust/pull/230#issuecomment-1978092643
> Sorry, I'm not sure if adding an IDE specific configuration is a good
choice. cc @Xuanwo @ZENOTME @Fokko WDYT?
@liurenjie1024 this is just a minor improvement aimed at enhan
liurenjie1024 commented on PR #230:
URL: https://github.com/apache/iceberg-rust/pull/230#issuecomment-1978074123
Sorry, I'm not sure if adding an IDE specific configuration is a good
choice. cc @Xuanwo @ZENOTME @Fokko WDYT?
--
This is an automated message from the Apache Git Service.
To r
tomtongue commented on code in PR #9849:
URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512208471
##
core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java:
##
@@ -196,56 +193,66 @@ public void testRollbacks() {
transaction.commitTransaction(
tomtongue commented on code in PR #9849:
URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512205833
##
core/src/test/java/org/apache/iceberg/TestBase.java:
##
@@ -745,6 +745,12 @@ void assertEquals(String context, Object expected, Object
actual) {
assertTh
tomtongue commented on code in PR #9849:
URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512205470
##
core/src/test/java/org/apache/iceberg/TestBatchScans.java:
##
@@ -51,27 +48,27 @@ public void testDataTableScan() {
BatchScan scan = table.newBatchScan();
pvary commented on PR #9606:
URL: https://github.com/apache/iceberg/pull/9606#issuecomment-1978057949
Thanks @huyuanfeng2018 for the PR and @stevenzwu for the review!
@huyuanfeng2018: Could you please backport the changes to Flink 1.17 and
1.16?
Thanks, Peter
--
This is an
pvary commented on issue #1881:
URL: https://github.com/apache/iceberg/issues/1881#issuecomment-1978055418
Is this still the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
stream2000 opened a new pull request, #230:
URL: https://github.com/apache/iceberg-rust/pull/230
Add IssueNavigationLink for RustRover
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
tomtongue commented on code in PR #9849:
URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512160426
##
core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java:
##
@@ -356,14 +353,14 @@ public void testPartitionsTableScanNoFilter() {
Ty
tomtongue commented on code in PR #9849:
URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512157166
##
core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java:
##
@@ -196,56 +193,66 @@ public void testRollbacks() {
transaction.commitTransaction(
nk1506 commented on issue #9085:
URL: https://github.com/apache/iceberg/issues/9085#issuecomment-1977995330
@tomtongue , I have reverted changed for the above files. As recommended by
@nastra I will work with `TestBase` for the related files.
--
This is an automated message from the Apac
tomtongue commented on code in PR #9849:
URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512150409
##
core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java:
##
@@ -31,49 +35,42 @@
import org.apache.iceberg.relocated.com.google.common.collect.Iter
tomtongue commented on code in PR #9849:
URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512141524
##
core/src/test/java/org/apache/iceberg/TestEntriesMetadataTable.java:
##
@@ -68,20 +63,19 @@ public void testEntriesTableScan() {
Schema expectedSchema =
tibercus closed issue #9773: Why does FlinkSink writes position deletes in
append-mode if identifier fields are specified?
URL: https://github.com/apache/iceberg/issues/9773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
tibercus commented on issue #9773:
URL: https://github.com/apache/iceberg/issues/9773#issuecomment-1977975169
@pvary Hi Peter!
Thanks, now that I know about changelog stream in Flink, the behaviour makes
perfect sense.
--
This is an automated message from the Apache Git Service.
To
mudit-97 commented on PR #9694:
URL: https://github.com/apache/iceberg/pull/9694#issuecomment-1977933726
sure @stevenzwu , thanks for the inputs, in our case, we were okay with data
duplication in non happy path scenarios but given your inputs, it might not be
okay with everyone. We can dis
zachdisc commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1512074114
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##
@@ -309,24 +312,6 @@ private List writePartitionedManifests(
zachdisc commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1512074114
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##
@@ -309,24 +312,6 @@ private List writePartitionedManifests(
zachdisc commented on PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#issuecomment-1977849542
@nastra nastra
> @zachdisc Hey Zach, sorry I was trying to experiment with refactoring the
current PR, but somehow the branch is public and I ended up directly committing
to it..
zachdisc commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1512037464
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/CustomDataFileSorterUdf.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation
zachdisc commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1512056511
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##
@@ -628,4 +613,50 @@ private Table table() {
return tabl
zachdisc commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1512056069
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##
@@ -628,4 +613,50 @@ private Table table() {
return tabl
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1512046593
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -269,6 +284,160 @@ public void renameTable(TableIdentifier from,
TableIdentifier orig
stevenzwu commented on PR #9606:
URL: https://github.com/apache/iceberg/pull/9606#issuecomment-1977835880
thanks @huyuanfeng2018 for the contribution and @pvary for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
stevenzwu merged PR #9606:
URL: https://github.com/apache/iceberg/pull/9606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
Xuanwo commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1977830450
> I've done a simple prototype with my hive-metastore running locally via
docker-compose, which works just fine. So testing via integration tests seems
to be no problem.
It'
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1511994436
##
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##
@@ -309,65 +304,20 @@ protected enum CommitStatus {
* @return Commit Status of Succ
szehon-ho commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1511970931
##
core/src/main/java/org/apache/iceberg/BaseMetastoreOperations.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
zachdisc commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1512037464
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/CustomDataFileSorterUdf.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation
huyuanfeng2018 commented on PR #9606:
URL: https://github.com/apache/iceberg/pull/9606#issuecomment-1977807670
> LGTM. just 2 nit comments to be addressed
done. @stevenzwu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
stevenzwu commented on PR #9865:
URL: https://github.com/apache/iceberg/pull/9865#issuecomment-1977787041
thanks @dramaticlly for clarifying the doc. I have always thought the 100
limit is applicable to nested fields. didn't know it is limited to the top
level.
--
This is an automated me
zachdisc commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1512015577
##
api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java:
##
@@ -44,6 +47,38 @@ public interface RewriteManifests
*/
RewriteManifests rewriteIf(Pre
flyrain commented on code in PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#discussion_r1512006182
##
pyiceberg/catalog/rest.py:
##
@@ -289,12 +291,25 @@ def auth_url(self) -> str:
else:
return self.url(Endpoints.get_token, prefixed=False)
dramaticlly opened a new pull request, #9865:
URL: https://github.com/apache/iceberg/pull/9865
Based on comment from
https://github.com/apache/iceberg/pull/5215/files#r915475413
and https://github.com/apache/iceberg/pull/5215/files#r915276052
100 as default limit is counted only
amogh-jahagirdar commented on code in PR #9860:
URL: https://github.com/apache/iceberg/pull/9860#discussion_r1511996190
##
core/src/test/java/org/apache/iceberg/TestMergeAppend.java:
##
@@ -92,6 +94,74 @@ public void testEmptyTableAppend() {
statuses(Status.ADDED, Statu
flyrain commented on code in PR #9839:
URL: https://github.com/apache/iceberg/pull/9839#discussion_r1511897858
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -178,15 +178,18 @@ public void initialize(String name, Map
unresolved) {
ConfigRespon
amogh-jahagirdar commented on code in PR #9860:
URL: https://github.com/apache/iceberg/pull/9860#discussion_r1511975142
##
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##
@@ -878,7 +886,7 @@ public Object updateEvent() {
@SuppressWarnings("checkstyle:
github-actions[bot] commented on issue #1881:
URL: https://github.com/apache/iceberg/issues/1881#issuecomment-1977708432
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
jackye1995 commented on PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#issuecomment-1977706910
There is a more general question of why this refactoring cannot be done at
API level, the key issue is that `RewriteManifests` cannot access the `Table`
object so it cannot construct t
jackye1995 commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1511961587
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/CustomDataFileSorterUdf.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundati
jackye1995 commented on code in PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#discussion_r1511961199
##
api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java:
##
@@ -44,6 +47,38 @@ public interface RewriteManifests
*/
RewriteManifests rewriteIf(P
jackye1995 commented on PR #9731:
URL: https://github.com/apache/iceberg/pull/9731#issuecomment-1977701904
@zachdisc Hey Zach, sorry I was trying to experiment with refactoring the
current PR, but somehow the branch is public and I ended up directly committing
to it...
Let me know if
stevenzwu commented on PR #9694:
URL: https://github.com/apache/iceberg/pull/9694#issuecomment-1977646231
In general, I feel unease of changing the Flink Iceberg sink behavior from
2pc to 1pc. Would at least have more broader community input before we think it
is good to add this option. Mi
bitsondatadev commented on code in PR #9861:
URL: https://github.com/apache/iceberg/pull/9861#discussion_r1511891884
##
format/spec.md:
##
@@ -791,7 +788,7 @@ Each version of table metadata is stored in a metadata
folder under the table’
Notes:
-1. The file system table sc
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1511883182
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2574,7 +2810,7 @@ components:
allOf:
- $ref: "#/components/schemas/TableRequirement"
descriptio
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1511880091
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2106,6 +2208,139 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1511879160
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2068,6 +2162,145 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1511873297
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2068,6 +2162,145 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
ndrluis commented on issue #497:
URL: https://github.com/apache/iceberg-python/issues/497#issuecomment-1977552814
After reading the `__init__.py` file in each namespace, I believe that this
problem exists only in the table, io and catalog namespaces.
Does anyone have suggestions on ho
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1511858632
##
open-api/rest-catalog-open-api.yaml:
##
@@ -537,6 +537,108 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1511857247
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2838,6 +3093,59 @@ components:
additionalProperties:
type: string
+PreplanTableRequest:
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1511852671
##
open-api/rest-catalog-open-api.yaml:
##
@@ -537,6 +537,108 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1511851647
##
open-api/rest-catalog-open-api.yaml:
##
@@ -537,6 +537,108 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1511851647
##
open-api/rest-catalog-open-api.yaml:
##
@@ -537,6 +537,108 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1509256679
##
open-api/rest-catalog-open-api.yaml:
##
@@ -537,6 +537,108 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1509256679
##
open-api/rest-catalog-open-api.yaml:
##
@@ -537,6 +537,108 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}
jackye1995 commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1509256679
##
open-api/rest-catalog-open-api.yaml:
##
@@ -537,6 +537,108 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}
ndrluis opened a new issue, #497:
URL: https://github.com/apache/iceberg-python/issues/497
### Apache Iceberg version
None
### Please describe the bug 🐞
When we import any functions that reside in `__init__.py`, it triggers the
execution of the code instead of merely imp
fqaiser94 commented on code in PR #6513:
URL: https://github.com/apache/iceberg/pull/6513#discussion_r1142716546
##
core/src/test/java/org/apache/iceberg/TestCustomValidations.java:
##
@@ -0,0 +1,643 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
ndrluis opened a new pull request, #496:
URL: https://github.com/apache/iceberg-python/pull/496
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
rahil-c commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1511704319
##
open-api/rest-catalog-open-api.yaml:
##
@@ -1581,6 +1608,17 @@ components:
type: string
example: [ "accounting", "tax" ]
+PageToken:
+ des
rahil-c commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1511701936
##
open-api/rest-catalog-open-api.yaml:
##
@@ -1581,6 +1608,17 @@ components:
type: string
example: [ "accounting", "tax" ]
+PageToken:
+ des
zeroshade commented on issue #63:
URL: https://github.com/apache/iceberg-go/issues/63#issuecomment-1977305156
> Is that correct? If so, I don't see createTable implemented yet. I think
that is required to test RenameTable. Should that be implemented first?
Most likely, yes.
--
This
jackye1995 commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1511679559
##
open-api/rest-catalog-open-api.yaml:
##
@@ -1581,6 +1608,17 @@ components:
type: string
example: [ "accounting", "tax" ]
+PageToken:
+
jackye1995 commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1511679559
##
open-api/rest-catalog-open-api.yaml:
##
@@ -1581,6 +1608,17 @@ components:
type: string
example: [ "accounting", "tax" ]
+PageToken:
+
jrouly commented on PR #490:
URL: https://github.com/apache/iceberg-python/pull/490#issuecomment-1977246026
@HonahX appreciate the review! Pushed a new commit with your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
flyrain commented on PR #9839:
URL: https://github.com/apache/iceberg/pull/9839#issuecomment-1977235781
Thanks @himadripal for working on it. Let me take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jrouly commented on code in PR #490:
URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1511608985
##
pyiceberg/catalog/glue.py:
##
@@ -93,6 +93,13 @@
if TYPE_CHECKING:
import pyarrow as pa
+
+# There is a unique Glue metastore in each AWS account and eac
jrouly commented on code in PR #490:
URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1511604893
##
pyiceberg/catalog/glue.py:
##
@@ -266,6 +289,10 @@ def __init__(self, name: str, **properties: Any):
)
self.glue: GlueClient = session.client("
jrouly commented on code in PR #490:
URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1511604071
##
pyiceberg/catalog/glue.py:
##
@@ -252,6 +259,22 @@ def _construct_database_input(database_name: str,
properties: Properties) -> Dat
return database_input
marvinlanhenke commented on issue #113:
URL: https://github.com/apache/iceberg-rust/issues/113#issuecomment-1977202916
@Xuanwo I've started looking into this (just started yesterday taking a look
at the codebase in general) - how would you go about unit testing the catalog
trait for hms? Th
stevenzwu commented on code in PR #9606:
URL: https://github.com/apache/iceberg/pull/9606#discussion_r1511504695
##
flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java:
##
@@ -64,26 +68,59 @@ public static Schema convert(TableSchema schema) {
RowTy
danielcweeks commented on code in PR #9860:
URL: https://github.com/apache/iceberg/pull/9860#discussion_r1511419189
##
core/src/main/java/org/apache/iceberg/BaseReplacePartitions.java:
##
@@ -87,31 +87,40 @@ public BaseReplacePartitions toBranch(String branch) {
@Override
nastra commented on code in PR #9860:
URL: https://github.com/apache/iceberg/pull/9860#discussion_r1511474175
##
core/src/test/java/org/apache/iceberg/TestMergeAppend.java:
##
@@ -92,6 +94,74 @@ public void testEmptyTableAppend() {
statuses(Status.ADDED, Status.ADDED));
JanKaul commented on PR #229:
URL: https://github.com/apache/iceberg-rust/pull/229#issuecomment-1977013448
PTAL @liurenjie1024 @Xuanwo @ZENOTME @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
bitsondatadev commented on code in PR #9861:
URL: https://github.com/apache/iceberg/pull/9861#discussion_r1511441289
##
format/spec.md:
##
@@ -791,7 +788,7 @@ Each version of table metadata is stored in a metadata
folder under the table’
Notes:
-1. The file system table sc
bitsondatadev commented on code in PR #9861:
URL: https://github.com/apache/iceberg/pull/9861#discussion_r1511432119
##
format/spec.md:
##
@@ -791,7 +788,7 @@ Each version of table metadata is stored in a metadata
folder under the table’
Notes:
-1. The file system table sc
1 - 100 of 145 matches
Mail list logo
