flyrain commented on code in PR #486:
URL: https://github.com/apache/iceberg-python/pull/486#discussion_r1512006182
##########
pyiceberg/catalog/rest.py:
##########
@@ -289,12 +291,25 @@ def auth_url(self) -> str:
else:
return self.url(Endpoints.get_token, prefixed=False)
+ def _extract_optional_oauth_params(self) -> Dict[str, str]:
+ set_of_optional_params = {AUDIENCE, RESOURCE}
Review Comment:
Can we include `SCOPE` as well since it is optional? This is pending #484.
##########
pyiceberg/catalog/rest.py:
##########
@@ -105,6 +105,8 @@ class Endpoints:
CREDENTIAL = "credential"
GRANT_TYPE = "grant_type"
SCOPE = "scope"
+AUDIENCE = "audience"
+RESOURCE = "resource"
Review Comment:
I think we will need a doc change as well. cc @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
