jrouly commented on code in PR #490:
URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1511608985
##########
pyiceberg/catalog/glue.py:
##########
@@ -93,6 +93,13 @@
if TYPE_CHECKING:
import pyarrow as pa
+
+# There is a unique Glue metastore in each AWS account and each AWS region. By
default, GlueCatalog chooses the Glue
+# metastore to use based on the user's default AWS client credential and
region setup. You can specify the Glue catalog
+# ID through glue.id catalog property to point to a Glue catalog in a
different AWS account. The Glue catalog ID is your
+# numeric AWS account ID.
+GLUE_ID = "glue.id"
Review Comment:
I went with `GLUE_ID` because it matches the Iceberg property (`glue.id`)
and because the other property constants below this do the same.
I went with `glue_catalog_id` when it's used because it is (imo) a better
name and maps more directly to the [AWS Glue
terminology](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-glue-database.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
