nastra commented on code in PR #9860:
URL: https://github.com/apache/iceberg/pull/9860#discussion_r1511474175
##########
core/src/test/java/org/apache/iceberg/TestMergeAppend.java:
##########
@@ -92,6 +94,74 @@ public void testEmptyTableAppend() {
statuses(Status.ADDED, Status.ADDED));
}
+ @Test
+ public void testEmptyTableAppendFilesWithDifferentSpecs() {
+ assertThat(listManifestFiles().size()).as("Table should start
empty").isEqualTo(0);
Review Comment:
```suggestion
assertThat(listManifestFiles().isEmpty();
```
or `.hasSize(0)`. Both are preferred, because they will actually print the
content of the collection if the assertion ever fails, whereas
`assertThat(listManifestFiles().size()).isEqualTo(xyz)` will only say `3 !=
xyz` without knowing what the content is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
