zachdisc commented on PR #9731: URL: https://github.com/apache/iceberg/pull/9731#issuecomment-1977849542
@nastra nastra > @zachdisc Hey Zach, sorry I was trying to experiment with refactoring the current PR, but somehow the branch is public and I ended up directly committing to it... > > Let me know if you agree with this or not, overall it tries to express the partition column sort order approach as a kind of sort function to minimize the if-else branches. I left a comment in the commit - I like the cleanliness of what you proposed but I don't think it yields quite as performant a result unfortunately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
